Date: Tue, 8 Jan 2008 15:36:52 +0100 (CET) From: Oliver Fromme <olli@secnetix.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: olli@secnetix.de Subject: ports/119453: [patch] Fix two small flaws in sysutils/bsdstats port Message-ID: <200801081436.m08Eaq6J093909@pluto.secnetix.de> Resent-Message-ID: <200801081500.m08F0CIO027238@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119453 >Category: ports >Synopsis: [patch] Fix two small flaws in sysutils/bsdstats port >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 08 15:00:07 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Oliver Fromme >Release: FreeBSD 7.0-PRERELEASE-20071018 i386 >Organization: secnetix GmbH & Co. KG http://www.secnetix.de/bsd >Environment: This patch applies to: ports/sysutils/bsdstats/files/300.statistics rev 1.40 >Description: (NB: I've sent this patch to the maintainer twice, but got no reply. I assume it's a technical problem because the maintainer was very responsive in the past. Maybe a spam filter thing. I'm now submitting this as a PR so it doesn't get lost completely.) The patch below fixes two small flaws in the port's periodic file: First there's a useless use of cat(1), and second there's a hardcoded directory name that should be replaced with the appropriate variable. Both are within the same line. >How-To-Repeat: n/a >Fix: --- 300.statistics.orig 2008-01-07 15:09:11.000000000 +0100 +++ 300.statistics 2008-01-07 15:11:33.000000000 +0100 @@ -239,7 +239,7 @@ get_id_token () { if [ -f $id_token_file ] then - if [ `cat /var/db/bsdstats | wc -l` -lt 3 ] + if [ `wc -l < $id_token_file` -lt 3 ] then rm $id_token_file fi >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801081436.m08Eaq6J093909>