Date: Sat, 08 Apr 2017 10:13:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218470] multimedia/handbrake hard codes gcc / ignores CC Message-ID: <bug-218470-13-7vZE3mMFbI@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-218470-13@https.bugs.freebsd.org/bugzilla/> References: <bug-218470-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218470 naito.yuichiro@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |naito.yuichiro@gmail.com --- Comment #1 from naito.yuichiro@gmail.com --- Do you mean the result of following log? http://package18.nyi.freebsd.org/data/110amd64-default-PR218330/2017-04-06_= 19h28m41s/logs/errors/handbrake-1.0.3.log HandBrake uses original configure script written in Python that uses hard coded 'gcc'. I made a quick fix for the configure script. Does this work as you expect? ``` Index: files/patch-make_configure.py =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- files/patch-make_configure.py (revision 437996) +++ files/patch-make_configure.py (working copy) @@ -36,6 +36,15 @@ grp.add_option( '--flatpak', default=3DFalse, action=3D'store_true', = help=3Dh ) cli.add_option_group( grp ) +@@ -1517,7 +1520,7 @@ try: + class Tools: + ar =3D ToolProbe( 'AR.exe', 'ar' ) + cp =3D ToolProbe( 'CP.exe', 'cp' ) +- gcc =3D ToolProbe( 'GCC.gcc', 'gcc', IfHost( 'gcc-4', '*-*-cy= gwin*' )) ++ gcc =3D ToolProbe( 'GCC.gcc', 'gcc', IfHost( 'gcc-4', '*-*-cy= gwin*' ), IfHost( os.environ['CC'], '*-*-freebsd*' )) + + if host.match( '*-*-darwin*' ): + gmake =3D ToolProbe( 'GMAKE.exe', 'make', 'gmake' ) @@ -1924,10 +1927,15 @@ int main() doc.add( 'GCC.sysroot', '' ) doc.add( 'GCC.minver', '' ) ``` --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218470-13-7vZE3mMFbI>