Date: Sun, 13 Jun 2010 19:02:46 +0200 From: Kai Wang <kaiwang27@gmail.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209122 - head/lib/libelf Message-ID: <20100613170246.GE2541@viskning> In-Reply-To: <20100613163710.GA62804@troutmask.apl.washington.edu> References: <201006131058.o5DAwo4b004987@svn.freebsd.org> <20100613163710.GA62804@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 13, 2010 at 09:37:10AM -0700, Steve Kargl wrote: > On Sun, Jun 13, 2010 at 10:58:50AM +0000, Kai Wang wrote: > > Author: kaiw > > Date: Sun Jun 13 10:58:50 2010 > > New Revision: 209122 > > URL: http://svn.freebsd.org/changeset/base/209122 > > > > Log: > > * Improve compatibility with existing application code by permitting the > > use of `elf_getbase()` on non-archive members. This change is needed > > for gcc LTO (-flto) to work properly. > > * Style fix: paranthesize returned values. > > * Document the current behaviour of `elf_getbase()`. > > > > Tested by: gerald, Steve Kargl (original patch) > > Obtained from: elftoolchain > > MFC after: 3 days > > > > Modified: > > head/lib/libelf/elf_getbase.3 > > head/lib/libelf/elf_getbase.c > > Thanks. Unfortunately without the patch to elf_update.c, > gcc LTO will not work (ie., 'gcc -flto -o z a.o b.o' will > segfault). Any chance that the elf_update.c patch will be > committed; possibly as a conditional compilation. The patch to elf_update.c needs some more work before it can be committed. We've concluded that our libelf is indeed overly strict about data alignment inside sections, so the problem will be fixed eventually. A ticket[1] has been created to track this issue. Thanks, Kai [1] http://sourceforge.net/apps/trac/elftoolchain/ticket/264
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100613170246.GE2541>