Date: Tue, 4 Apr 2017 19:21:58 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: Kyle Evans <kevans91@ksu.edu>, Conrad Meyer <cem@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Dimitry Andric <dim@freebsd.org> Subject: Re: svn commit: r316492 - in head/usr.bin/grep: . regex Message-ID: <73AAB945-B506-4986-AAF8-A922AF38C496@gmail.com> In-Reply-To: <25D20383-8A5B-4F78-B8B4-12F9B3521626@FreeBSD.org> References: <201704041608.v34G8qSo055328@repo.freebsd.org> <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> <B9C5AC3B-1775-4D5D-ADA7-C6CE091F32F5@FreeBSD.org> <CAG6CVpVQ1pFdeCg-OJNGcGd1rbJ1CMDEyfEa3FWd9HEsrSfrUw@mail.gmail.com> <2CA2F0F0-17E4-4E9F-BDD6-10EDFECDB679@gmail.com> <CACNAnaFPoj8d=DpEbeyNj9ECGzuVRWo4S-HR7%2BDyB74HACoF=g@mail.gmail.com> <25D20383-8A5B-4F78-B8B4-12F9B3521626@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 4, 2017, at 19:21, Pedro Giffuni <pfg@FreeBSD.org> wrote: >=20 >> On Apr 4, 2017, at 14:48, Kyle Evans <kevans91@ksu.edu> wrote: >>=20 >> On Tue, Apr 4, 2017 at 2:45 PM, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >>=20 >> > On Apr 4, 2017, at 12:04, Conrad Meyer <cem@freebsd.org> wrote: >> > >> > On Tue, Apr 4, 2017 at 11:56 AM, Dimitry Andric <dim@freebsd.org> = wrote: >> >> On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >> >>> Where did xmalloc.c originate from? >> >> >> >> GNU. >> > >> > I believe this to be completely incorrect. >> > >> >> Almost all software from the GNU project relies on malloc wrappers >> >> which abort the program on allocation failures. >> > >> > That is not what bsdgrep's xmalloc() did, if you read the code. It >> > simply tracks all allocations for basic leak analysis. >> > >> > Abort on allocation failure would be a perfectly reasonable = behavior >> > for bsdgrep(1), too. >>=20 >> There are multiple, competing definitions floating around the = internet. I was genuinely curious where this variant came from because I = wanted to make sure we weren=E2=80=99t just zapping a file that some = upstream uses somewhere, in the event we were going to bring down = further updates, again, from said upstream source. >>=20 >> FWIW- I did scour the internet for other bsdgrep implementations and = did not find a trace of this in any of the others that I found, to = include the OS X implementation. In fact, as I recall, most of them = didn't even have the regex/ bits that we do, presumably they were using = regex(3) but it's been a while since I was poking around. >=20 > Well, for the history of bsdgrep, you have to go back to freegrep: >=20 > https://jameshoward.us/software/freegrep/ >=20 > but the most significant changes are likely to be due to Gabor: >=20 > https://wiki.freebsd.org/BSDgrep So=E2=80=A6. Gabor added xmalloc then ;p=E2=80=A6 -Ngie --Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY5FTGAAoJEPWDqSZpMIYVzJoP/2J2GJ0GWcC9fTkOHdMUe08w fAUVSiRL/dn8OKbHrdITlzPY3aoglXLRLETmNn80YYxxrLI3OpjQhxItHpM4Hmib u1nAp46Bo9W4pt68I+J5ITsrApEr7K/XE5D6Cg2IbWzVd4/seBM4k/qOn6aP2tA7 4W2zn1O2Wprsm4+MZEtsu9pr5o256vqDhBkzLJWIBtDIePEVSHypS/ZyuxDefrTX /K5rCedjHxZOpGdNBc4LbaSgu0kEZs+yChGwE9pqtIltCEfv1el1QbKljQw70WE1 bccJ1fYOKYWMfyoDlPzZ0NWZq6adL/hM+GVR6SBTM4avU/i8oCcZJ7tNgM8WhFzM AB69pTXfRj95OCEgG8I+d3ZDXeE3h2DYe2L9Uj0zqL4v/8O+nxsVpZJN1Rx3ZGBs 2NPksq7VjPm2RsSidbRFWCy1p7qhymgaiiw5g+10ilFQzHUpm0o4Gz+FjFxMTeiq g4N9lr3IeEPt8Rz0XfFQTRIKF6PbK0PaiZURLCExkZ/SIHyb0Mhtrqllu8XJHAyj xDH6kHSNhl0EETdt3/c5SpyxA8W8I1YmodbOnfzkmRpnEpHJ7Fljw/K+zkVNuznh /Wb3sWVTm5cM3mCZpLV8AMN4E4vTT7ZUb0qZrZs8VwLrWNFEK2HNCwOwTPrVMFTS M+SQBYgQsqH3C88dmKx5 =Rwgb -----END PGP SIGNATURE----- --Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73AAB945-B506-4986-AAF8-A922AF38C496>