Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 5 Nov 2018 22:07:08 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r484251 - in head/math/qtoctave: . files
Message-ID:  <201811052207.wA5M787f063566@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: tobik
Date: Mon Nov  5 22:07:08 2018
New Revision: 484251
URL: https://svnweb.freebsd.org/changeset/ports/484251

Log:
  math/qtoctave: Unbreak build with Clang 6
  
  qtoctave/src/generate_menu.cpp:282:64: error: cannot initialize return object of type 'MenuExtCallBack *' with an rvalue of type 'bool'
          if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) return false;
                                                                        ^~~~~
  
  http://beefy3.nyi.freebsd.org/data/112amd64-quarterly/482201/logs/qtoctave-0.10.1_4.log
  
  PR:		232985
  Submitted by:	w.schwarzenfeld@utanet.at

Added:
  head/math/qtoctave/files/patch-qtoctave__src-generate_menu.cpp   (contents, props changed)
Modified:
  head/math/qtoctave/Makefile

Modified: head/math/qtoctave/Makefile
==============================================================================
--- head/math/qtoctave/Makefile	Mon Nov  5 21:46:35 2018	(r484250)
+++ head/math/qtoctave/Makefile	Mon Nov  5 22:07:08 2018	(r484251)
@@ -9,8 +9,6 @@ MASTER_SITES=	http://forja.rediris.es/frs/download.php
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Qt 4 frontend for Octave
 
-BROKEN=		fails to build
-
 RUN_DEPENDS=	octave:math/octave
 
 USE_QT=		designer gui network script svg xml \

Added: head/math/qtoctave/files/patch-qtoctave__src-generate_menu.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/math/qtoctave/files/patch-qtoctave__src-generate_menu.cpp	Mon Nov  5 22:07:08 2018	(r484251)
@@ -0,0 +1,11 @@
+--- qtoctave/src/generate_menu.cpp.orig	2018-11-05 13:09:19 UTC
++++ qtoctave/src/generate_menu.cpp
+@@ -279,7 +279,7 @@ bool GenerateMenu::process_menu_file(QSt
+ MenuExtCallBack *GenerateMenu::process_menu_file(QString _file)
+ {
+ 	QFile file(_file);
+-	if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) return false;
++	if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) return NULL;
+ 	
+ 	QString label;
+ 	MenuExtCallBack *wizard=new MenuExtCallBack();

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811052207.wA5M787f063566>