Date: Wed, 17 Jul 2002 09:12:16 -0400 (EDT) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Bruce Evans <bde@zeta.org.au> Cc: John Baldwin <jhb@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: RE: cvs commit: src/sys/kern kern_condvar.c kern_shutdown.c kern Message-ID: <15669.27952.598634.585316@grasshopper.cs.duke.edu> In-Reply-To: <20020717164015.J4112-100000@gamplex.bde.org> References: <XFMail.20020716223015.jhb@FreeBSD.org> <20020717164015.J4112-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans writes:
> On Tue, 16 Jul 2002, John Baldwin wrote:
>
> > On 17-Jul-2002 Andrew Gallatin wrote:
> > > gallatin 2002/07/16 19:23:44 PDT
> > >
> > > Modified files:
> > > sys/kern kern_condvar.c kern_shutdown.c
> > > kern_switch.c kern_synch.c
> > > sys/sys proc.h
> > > Log:
> > > Allow alphas to do crashdumps: Refuse to run anything in choosethread()
> > > after a panic which is not an interrupt thread, or the thread which
> > > caused the panic. Also, remove panicstr checks from msleep() and from
> > > cv_wait() in order to allow threads to go to sleep and yeild the cpu
> > > to the panicing thread, or to an interrupt thread which might
> > > be doing the crashdump.
> > >
> > > Reviewed by: jhb (and it was mostly his idea too)
> >
> > You might want to integrate some of bde's suggestions on fixing up
> > comments, etc.
>
> Also ones to not fix it this way :-). Only the panicing thread should
> run once panic() is reached. The crashdump part of panic came close
> to doing this in RELENG_4 but has rotted.
I whole-heartedly agree with you. But fixing things to work correctly
is way beyond the amount of time I have available. My sole intent was
to put enough of a bandaid on this so that crashdumps work again on
alpha.
In terms of bitrot removal in the comments, would the removal of the
second sentence of the following comment in both msleep() and its
clone in cv_timedwait() be sufficient?
/*
* During autoconfiguration, just give interrupts
* a chance, then just return.
* Don't run any other procs or panic below,
* in case this is the idle process and already asleep.
*/
Becomes:
/* During autoconfiguration, just return */
Thanks,
Drew
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15669.27952.598634.585316>