Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Oct 2007 07:04:32 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Pyun YongHyeon <pyunyh@gmail.com>
Cc:        freebsd-current@FreeBSD.org
Subject:   Re: CFT: vr(4)
Message-ID:  <20071008070345.E6043@maildrop.int.zabbadoz.net>
In-Reply-To: <20071008061758.GF46694@cdnetworks.co.kr>
References:  <20071008061758.GF46694@cdnetworks.co.kr>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 8 Oct 2007, Pyun YongHyeon wrote:

> It seems that there had been several stability issues in vr(4).
> Here is mimimal patch that make vr(4) work reliably under heavy
> network loads. The patch does the following:
> - Always check writability of mbuf before padding and make a
>   writable copy of the mbuf if mbuf is marked as read-only.
> - Before padding is done check remaining bytes such that it can
>   safely extend buffer size of the mbuf.
> - Before padding always check the return value of m_defrag(9).
> - Zero out pad space to avoid leaking data.
>
> If you have vr(4) hardware please give it spin and let me know
> the result.

Had you seen wpaul's posting to net@ a few weeks ago. That had a patch
attached as well. What about that?

-- 
Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
Software is harder than hardware  so better get it right the first time.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071008070345.E6043>