Date: Fri, 30 Dec 2016 10:38:26 -0800 From: John Baldwin <jhb@freebsd.org> To: Alexander Kabaev <kan@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam Message-ID: <2270028.8V7VsJ8Web@ralph.baldwin.cx> In-Reply-To: <201612292130.uBTLUqus011628@repo.freebsd.org> References: <201612292130.uBTLUqus011628@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 29, 2016 09:30:52 PM Alexander Kabaev wrote: > Author: kan > Date: Thu Dec 29 21:30:52 2016 > New Revision: 310789 > URL: https://svnweb.freebsd.org/changeset/base/310789 > > Log: > Use compiler driver to build relocatable object > > This works better with external toolchains where LD > will not necessarily defailt to emulation we want. > Compiler driver knows better. I think this was the case I had added the XLDFLAGS in my mips cross-building patches for. I'm fine with dropping the XLDFLAGS bits and depending on the compiler driver if we think that is the better solution. > Modified: > head/lib/libpam/static_libpam/Makefile > > Modified: head/lib/libpam/static_libpam/Makefile > ============================================================================== > --- head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:06:31 2016 (r310788) > +++ head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:30:52 2016 (r310789) > @@ -64,6 +64,6 @@ CLEANFILES+= openpam_static.o \ > openpam_static_modules.o > > openpam_static_modules.o: openpam_static.o ${STATIC_MODULES} > - ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC} > + ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC} > > .include "${.CURDIR}/../libpam/Makefile" > -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2270028.8V7VsJ8Web>