Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Sep 2005 13:59:35 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        src-committers@FreeBSD.org
Cc:        cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/rm rm.1 rm.c
Message-ID:  <433C55B7.8060901@FreeBSD.org>
In-Reply-To: <200509292040.j8TKeTPf068156@repoman.freebsd.org>
References:  <200509292040.j8TKeTPf068156@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton wrote:
> dougb       2005-09-29 20:40:29 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     bin/rm               rm.1 rm.c 
>   Log:
>   Handle the case where the -P flag is specified for a read-only file
>   earlier, and more gracefully. Previously, this combination would be
>   ignored early in the code where permissions are tested and fail later
>   with a very unhelpful "permission denied" error.
>   
>   Instead, test for this flag in the same block that generates the
>   "override?" messages for read-only files, but instead of trying
>   to guess what the user has in mind, generate an error and exit.
>   
>   Update the man page to reflect this new behavior.
>   
>   Not objected to by:     freebsd-hackers@
>   
>   Revision  Changes    Path
>   1.37      +4 -0      src/bin/rm/rm.1
>   1.53      +5 -4      src/bin/rm/rm.c
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/bin/rm/rm.1.diff?&r1=1.36&r2=1.37&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/bin/rm/rm.c.diff?&r1=1.52&r2=1.53&f=h

Assuming there is no overwhelming bikeshed over this change, I'll request an 
MFC prior to 6.0-RELEASE.

I am of course still willing to listen to rational arguments about why this 
change might be a bad idea, or could be handled in a better way.

Doug

-- 

     This .signature sanitized for your protection




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?433C55B7.8060901>