Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Oct 2010 22:06:09 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Bernhard Schmidt <bschmidt@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r214070 - head/sys/dev/if_ndis
Message-ID:  <20101019220455.D46881@maildrop.int.zabbadoz.net>
In-Reply-To: <201010191911.o9JJBaQe024210@svn.freebsd.org>
References:  <201010191911.o9JJBaQe024210@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Oct 2010, Bernhard Schmidt wrote:

> Author: bschmidt
> Date: Tue Oct 19 19:11:36 2010
> New Revision: 214070
> URL: http://svn.freebsd.org/changeset/base/214070
>
> Log:
>  There is no reason to call rt_ifmsg(), remove it.

While it's indeed very uncommon to have that in a driver, I don't know
how much black magic if_ndis(4) is.  Have you verified that you still
get the events from elsewhere on the routing socket when
loading/unloading if_ndif.ko?


>  Submitted by:	Paul B Mahol <onemda at gmail.com>
>  MFC after:	1 week
>
> Modified:
>  head/sys/dev/if_ndis/if_ndis.c
>
> Modified: head/sys/dev/if_ndis/if_ndis.c
> ==============================================================================
> --- head/sys/dev/if_ndis/if_ndis.c	Tue Oct 19 18:49:26 2010	(r214069)
> +++ head/sys/dev/if_ndis/if_ndis.c	Tue Oct 19 19:11:36 2010	(r214070)
> @@ -1644,10 +1644,6 @@ ndis_linksts_done(adapter)
> 	default:
> 		break;
> 	}
> -
> -	/* Notify possible listners of interface change. */
> -
> -	rt_ifmsg(ifp);
> }
>
> static void
>

-- 
Bjoern A. Zeeb                              Welcome a new stage of life.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101019220455.D46881>