Date: Fri, 2 Jan 2015 22:49:06 +0000 (UTC) From: Jilles Tjoelker <jilles@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r276590 - in head: contrib/netbsd-tests/lib/libc/c063 lib/libc/tests/c063 Message-ID: <201501022249.t02Mn6VN003573@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jilles Date: Fri Jan 2 22:49:05 2015 New Revision: 276590 URL: https://svnweb.freebsd.org/changeset/base/276590 Log: Link lib/libc/c063 tests to the build. Some files lack required #include <sys/stat.h>. The #ifdef is per ngie's request; the includes are clearly necessary for struct stat. The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with faccessat(), which is not specified by POSIX.1-2008. Differential Revision: https://reviews.freebsd.org/D1411 Reviewed by: ngie Modified: head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c head/lib/libc/tests/c063/Makefile Modified: head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c ============================================================================== --- head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c Fri Jan 2 22:45:55 2015 (r276589) +++ head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c Fri Jan 2 22:49:05 2015 (r276590) @@ -165,6 +165,9 @@ ATF_TC_BODY(faccessat_fdlink, tc) ATF_REQUIRE(faccessat(dfd, BASELINK, F_OK, 0) == -1); ATF_REQUIRE(errno == ENOENT); +#ifdef __FreeBSD__ + atf_tc_expect_fail("Depends on non-standard behavior not mentioned in POSIX.1-2008"); +#endif ATF_REQUIRE(faccessat(dfd, BASELINK, F_OK, AT_SYMLINK_NOFOLLOW) == 0); ATF_REQUIRE(close(dfd) == 0); Modified: head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c ============================================================================== --- head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c Fri Jan 2 22:45:55 2015 (r276589) +++ head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c Fri Jan 2 22:49:05 2015 (r276590) @@ -40,6 +40,9 @@ __RCSID("$NetBSD: t_fchmodat.c,v 1.2 201 #include <string.h> #include <unistd.h> #include <sys/param.h> +#ifdef __FreeBSD__ +#include <sys/stat.h> +#endif #define DIR "dir" #define FILE "dir/fchmodat" Modified: head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c ============================================================================== --- head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c Fri Jan 2 22:45:55 2015 (r276589) +++ head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c Fri Jan 2 22:49:05 2015 (r276590) @@ -41,6 +41,9 @@ __RCSID("$NetBSD: t_fchownat.c,v 1.3 201 #include <unistd.h> #include <pwd.h> #include <sys/param.h> +#ifdef __FreeBSD__ +#include <sys/stat.h> +#endif #define DIR "dir" #define FILE "dir/fchownat" Modified: head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c ============================================================================== --- head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c Fri Jan 2 22:45:55 2015 (r276589) +++ head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c Fri Jan 2 22:49:05 2015 (r276590) @@ -40,6 +40,9 @@ __RCSID("$NetBSD: t_fstatat.c,v 1.2 2013 #include <string.h> #include <unistd.h> #include <sys/param.h> +#ifdef __FreeBSD__ +#include <sys/stat.h> +#endif #define DIR "dir" #define FILE "dir/fstatat" Modified: head/lib/libc/tests/c063/Makefile ============================================================================== --- head/lib/libc/tests/c063/Makefile Fri Jan 2 22:45:55 2015 (r276589) +++ head/lib/libc/tests/c063/Makefile Fri Jan 2 22:49:05 2015 (r276590) @@ -4,21 +4,23 @@ TESTSDIR= ${TESTSBASE}/lib/libc/c063 #TODO: t_o_search, t_utimensat -NETBSD_ATF_TESTS_C= t_faccessat -NETBSD_ATF_TESTS_C+= t_fchmodat -NETBSD_ATF_TESTS_C+= t_fchownat -NETBSD_ATF_TESTS_C+= t_fexecve -NETBSD_ATF_TESTS_C+= t_fstatat -NETBSD_ATF_TESTS_C+= t_linkat -NETBSD_ATF_TESTS_C+= t_mkdirat -NETBSD_ATF_TESTS_C+= t_mkfifoat -NETBSD_ATF_TESTS_C+= t_mknodat -NETBSD_ATF_TESTS_C+= t_openat -NETBSD_ATF_TESTS_C+= t_readlinkat -NETBSD_ATF_TESTS_C+= t_renameat -NETBSD_ATF_TESTS_C+= t_symlinkat -NETBSD_ATF_TESTS_C+= t_unlinkat +NETBSD_ATF_TESTS_C= faccessat +NETBSD_ATF_TESTS_C+= fchmodat +NETBSD_ATF_TESTS_C+= fchownat +NETBSD_ATF_TESTS_C+= fexecve +NETBSD_ATF_TESTS_C+= fstatat +NETBSD_ATF_TESTS_C+= linkat +NETBSD_ATF_TESTS_C+= mkdirat +NETBSD_ATF_TESTS_C+= mkfifoat +NETBSD_ATF_TESTS_C+= mknodat +NETBSD_ATF_TESTS_C+= openat +NETBSD_ATF_TESTS_C+= readlinkat +NETBSD_ATF_TESTS_C+= renameat +NETBSD_ATF_TESTS_C+= symlinkat +NETBSD_ATF_TESTS_C+= unlinkat CFLAGS+= -D_INCOMPLETE_XOPEN_C063 +.include "../Makefile.netbsd-tests" + .include <bsd.test.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501022249.t02Mn6VN003573>