Date: Mon, 10 Feb 2014 15:30:07 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: svn-ports-head@FreeBSD.org, Steve Wills <swills@FreeBSD.org>, svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>, David Chisnall <theraven@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210143007.GD80056@ithaqua.etoilebsd.net> In-Reply-To: <B5D7D76E-4F1E-4A27-8835-E34A46CB6AE8@adamw.org> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net> <E8F403F4-EA83-4F71-82E6-9BA27D8D217C@FreeBSD.org> <20140210101243.GX80056@ithaqua.etoilebsd.net> <B5D7D76E-4F1E-4A27-8835-E34A46CB6AE8@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4JxvUTD846AMAZAS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 09:10:06AM -0500, Adam Weinberger wrote: > On 10 Feb 2014, at 5:12, Baptiste Daroussin wrote: >=20 > > On Mon, Feb 10, 2014 at 09:47:17AM +0000, David Chisnall wrote: > >> On 10 Feb 2014, at 07:52, Baptiste Daroussin <bapt@FreeBSD.org>=20 > >> wrote: > >> > >>> I do not think that requires an approval, as for FreeBSD this change= =20 > >>> is no-op, > >>> It is also no intrusive and just "fixes" building of that port for=20 > >>> Dragonfly. > >> > >> Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. = =20 > >> Already we have problems with convoluted OSVERSION expressions that=20 > >> are hard to understand and really mean 'fix for PR12345 has been=20 > >> merged to the relevant branch'. It would be far better to centralise= =20 > >> these into a single file for each platform, listing features /=20 > >> bugfixes / needed work-arounds and start removing explicit OSVERSION= =20 > >> checks from any other Makefiles. If supporting Dragonfly is one of=20 > >> our objectives, then I'd strongly encourage the people who are=20 > >> working on it to engage in this kind of cleanup, rather than piling=20 > >> more hacks into the tree. > >> > >> David > >> > > > > If one has a nice idea to centralize those informations I'm all about= =20 > > it, by > > nice idea I mean format and implementation. > > > > May that be OPSYS and/or OSVERSION both requires loading too many=20 > > times bsd.*.mk > > which is not good, looking forward for propositions. > > > > regards, > > Bapt >=20 > pkgconf. It's ISC-licenced, has no external dependencies, and would be a= =20 > great way to store information about the system itself. Instead of using= =20 > magic to guess which compiler to use, a compiler.pc could tell you. The= =20 > mayhem that ensued when the threading library changed years ago, a=20 > thread.pc would have made it a piece of cake. You could store=20 > capabilities in .pc files and have a single reliable way to retrieve it. >=20 Given I'm upstream on pkgconf, I know a bit about it, but I still do not se= e how pkgconf can help us here :) regards, Bapt --4JxvUTD846AMAZAS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL44m8ACgkQ8kTtMUmk6Ex5fgCeN9SFEUiY0ySKGRnCpnZvMDrU GQIAn3v+9DFFWAjioxJMk8TNTX7suyz5 =jwpg -----END PGP SIGNATURE----- --4JxvUTD846AMAZAS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140210143007.GD80056>