Date: Sun, 16 Jun 2002 09:34:18 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Pete Fritchman <petef@absolutbsd.org> Cc: Alexey Zelkin <phantom@ark.cris.net>, Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/calendar Makefile Message-ID: <20020616000418.GE65995@wantadilla.lemis.com> In-Reply-To: <20020615195035.A79216@absolutbsd.org> References: <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614191040.H2820-100000@gamplex.bde.org> <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614121629.A26139@ark.cris.net> <20020614191040.H2820-100000@gamplex.bde.org> <20020615231946.GA65995@wantadilla.lemis.com> <20020615195035.A79216@absolutbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 15 June 2002 at 19:50:35 -0400, Pete Fritchman wrote:
> ++ 16/06/02 08:49 +0930 - Greg 'groggy' Lehey:
>>> It is a style bug at best to create destination directories directly,
>>> especially using mkdir -p instead of install -d to ensure having little
>>> control over the directories' attributes.
>>
>> I tried install -d first, and got problems which suggested that I was
>> misunderstanding its use. Here's the rule I had:
>>
>> .for lang in ${INTER}
>> ${INSTALL} -d -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
>> ${.CURDIR}/calendars/${lang}/calendar.* \
>> ${DESTDIR}${SHAREDIR}/calendar/${lang}
>> .endfor
>
> install -d just creates the directory, it doesn't put files there too.
>
> entropy(~) [121] > install -d foo
> entropy(~) [122] > ls -ld foo
> drwxr-xr-x 2 petef wheel 512 Jun 15 19:50 foo/
> entropy(~) [123] >
Ah, thanks. So what about this?
.for lang in ${INTER}
install -d -o ${BINOWN} -g ${BINGRP} -m ${DIRMODE} ${DESTDIR}${SHAREDIR}/calendar/${lang}
${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
${.CURDIR}/calendars/${lang}/calendar.* \
${DESTDIR}${SHAREDIR}/calendar/${lang}
.endfor
I know that this doesn't address the question about whether this
should be done by mtree or not. Normally it would, but I don't
believe that the 'make install' should fail because it's done in the
directory.
Greg
--
See complete headers for address and phone numbers
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020616000418.GE65995>