Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jun 2001 17:33:48 +0100 (BST)
From:      Doug Rabson <dfr@nlsystems.com>
To:        <freebsd-ppc@FreeBSD.org>
Cc:        <freebsd-current@FreeBSD.org>
Subject:   Re: FreeBSD/powerpc commit candidate for review
Message-ID:  <Pine.BSF.4.33.0106051722350.7828-100000@herring.nlsystems.com>
In-Reply-To: <20010605215845.A4095@rafe.jeamland.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 5 Jun 2001, Benno Rice wrote:

> After considration of the last patchset I put up, I decided to get the
> stuff in a slightly cleaner condition before I committed.
>
> The results are now at:
> 	http://people.freebsd.org/~benno/commit/powerpc.diff
>
> There's still a lot of commented or #if 0'd out code, but I've cleaned up
> a lot of warnings, did a style pass of sorts and also managed to get VM
> initialising properly. =)
>
> You can see the current boot messages from my iMac at:
> 	http://jeamland.net/~benno/powerpc-boot.txt
>
> It hangs after the mountroot> prompt.
>
> I'd like to commit this around the end of this week.
>
> Replies have been set to go to freebsd-ppc.

Congratulations on the progress so far!

You probably want to fix the $FreeBSD$ in md_var.h and maybe change/delete
the alpha specific stuff there. Come to think about it, there are several
cases where the $FreeBSD$ header still shows the location where the file
was copied from. The cvs scripts should stop you from committing these
files until that is fixed.

I notice that reloc.h is just the copyright message. I guess you ought to
use your own copyright here instead of John Birrell's. Come to think of
it, the same thing could be said of alpha/include/reloc.h. Perhaps this
header could be removed entirely if the contents of i386/include/reloc.h
found a better home.

Other than those minor comments, I think it looks ready to commit.

-- 
Doug Rabson				Mail:  dfr@nlsystems.com
					Phone: +44 20 8348 6160



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.33.0106051722350.7828-100000>