Date: Sun, 23 Jun 2019 10:43:31 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: Christoph Moench-Tegeder <cmt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504800 - in head/cad: . kicad-doc Message-ID: <20190623104331.GA22325@FreeBSD.org> In-Reply-To: <20190621212800.GA2542@elch.exwg.net> References: <201906211352.x5LDq1E6071357@repo.freebsd.org> <20190621145405.GA390@FreeBSD.org> <20190621212800.GA2542@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 21, 2019 at 11:28:00PM +0200, Christoph Moench-Tegeder wrote: > ## Alexey Dokuchaev (danfe@freebsd.org): > ... > > > +NO_ARCH= yes > > > > This knob should appear earlier. > > Where? I can't find it anywhere in "Order of Variables" (Ch. 15 of > the Porter's Handbook), so I was putting it at the end, as in "The > Rest of the Variables") and portlint didn't complain. And looking > at other ports, the situation is... not clear. Typically, a port's Makefile logic roughly corresponds to how people build and package a piece of software: they first learn about it, then downlod it, then patch, then build, then package, then install. Ergo, it's naturally layed out like this: <general info about the software: PORTNAME/PORTVERSION/CATEGORIES/...> <MAINTAINER, COMMENT, and LICENSE> <*_DEPENDS lines> <sometimes, GitHub-related knobs go here, separated from the USES because it's more fetch-related rather then build-related like the other USE_* knobs, but this is largely a personal preference> <various generic build-related knobs: USES, USE_*, *_CONFIGURE, WRKSRC, NO_BUILD, *_TARGET, etc.; sometimes they are split into subgroups for readability, e.g. CC/CXXFLAGS, MAKE_ENV/ARGS are often go together> <package-related knobs: INFO, PLIST_FILES, PORTDOCS, PORTEXAMPLES> <OPTIONS block + their helpers> <targets (recipes)> .include <bsd.port.mk> So by that logic, I'd place NO_ARCH higher in the Makefile, around with other generic build-related knobs. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190623104331.GA22325>