Date: Tue, 1 Oct 2013 09:27:48 +0900 From: Takuya ASADA <syuu@dokukino.com> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: Flow Director statistics for ixgbe(4) Message-ID: <CALG4x-VnAVCt1iWbk4O5zLh-kTK8M-QHdVCW-q6HUWyoQ6-3%2BQ@mail.gmail.com> In-Reply-To: <CALCpEUHPgZxYtFtd92VyuFg49W9XXr-gxgzG6T5JU93Ou6xvdg@mail.gmail.com> References: <CALG4x-W302xOS0P3580UCdJaTDsKq5NiZgcoFBi2jyv9CoQ3%2Bw@mail.gmail.com> <CALCpEUGkjMXdFFdU-NzXMZ9nonB4PttJm7MBqtvqUHn8ertJXA@mail.gmail.com> <CALG4x-V3VpqVoDwinvphRHH8akeo2harrKWHK%2BHRV8JOMsWbrQ@mail.gmail.com> <CALCpEUHPgZxYtFtd92VyuFg49W9XXr-gxgzG6T5JU93Ou6xvdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/10/1 hiren panchasara <hiren.panchasara@gmail.com> > > > > On Mon, Sep 30, 2013 at 1:48 PM, Takuya ASADA <syuu@dokukino.com> wrote: > >> Hi, >> >> descriptions are added. >> > > Great. > > My minor suggestions (you can ignore them :-)) > > from > "Number of filters addition events that do not change the number of free" > to > "Number of failed filter addition events" > > (I believe, "do not change the number of free" part is given when addition > is failing) > The specification says: Number of filters addition events that do not change the number of free (non programmed) filters in the flow director filters logic (FDIRFREE.FREE). These events can be either filters update, filters collision, or tentative of filter additions when there is no sufficient space remaining in the filter table. The counter is stacked at 0xFF and cleared on read. So it's not just failing addition, but also update(filter already exists && filter update succeeded), filter collision, and no space to add filter(add failing). I haven't good idea to describe this.. > from > "Number of packets that missed matched any flow director filter" > to > "Number of packets that didn't match any flow director filter" > > >> >> 2013/10/1 hiren panchasara <hiren.panchasara@gmail.com> >> >>> >>> >>> >>> On Mon, Sep 30, 2013 at 12:02 PM, Takuya ASADA <syuu@dokukino.com>wrote: >>> >>>> Hi, >>>> >>>> This is originally part of "ixgbetool" patch, but I think it can be >>>> discuss >>>> separately: >>>> >>>> http://freebsd.1045724.n5.nabble.com/Adding-Flow-Director-sysctls-to-ixgbe-4-was-netmap-traffic-distribution-tp5847066p5847789.html >>>> >>>> I implemented sysctls to expose Flow Director statistics. >>>> It works like this: >>>> $ sysctl dev.ix.0.mac_stats|grep fdir >>>> dev.ix.0.mac_stats.fdirfree_free: 8192 >>>> dev.ix.0.mac_stats.fdirfree_coll: 0 >>>> dev.ix.0.mac_stats.fdirustat_add: 0 >>>> dev.ix.0.mac_stats.fdirustat_remove: 0 >>>> dev.ix.0.mac_stats.fdirfstat_fadd: 0 >>>> dev.ix.0.mac_stats.fdirfstat_fremove: 0 >>>> dev.ix.0.mac_stats.fdirmatch: 0 >>>> dev.ix.0.mac_stats.fdirmiss: 23 >>>> >>> >>> I am running this with the ixgbetool patch you have and only 1 issue >>> I've seen so far: fdirustat_add increments on adding a filter but >>> fdirustat_remove does not on deleting one (if thats how its supposed to >>> work) >>> >> > As we talked on another thread, yes, problem is just the counter not > getting updated. The functionality is fine. > > > Appreciate your awesome work. > > Cheers, > Hiren > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALG4x-VnAVCt1iWbk4O5zLh-kTK8M-QHdVCW-q6HUWyoQ6-3%2BQ>