Date: Mon, 8 May 2000 08:33:31 +0930 From: Greg Lehey <grog@lemis.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: FreeBSD-arch@FreeBSD.ORG Subject: Tidiness or kernel bloat? (was: Support for bootable Vinum file systems: please review) Message-ID: <20000508083331.A61488@freebie.lemis.com> In-Reply-To: <12575.957698677@critter.freebsd.dk> References: <20000507202944.I55316@freebie.lemis.com> <12575.957698677@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 7 May 2000 at 13:24:37 +0200, Poul-Henning Kamp wrote: > In message <20000507202944.I55316@freebie.lemis.com>, Greg Lehey writes: > >>>> >>>> This is pretty much what struct devstat does, except that it's more >>>> global. Why should we maintain two lists, just because one is >>>> primarily intended for statistics? >>>> >>>> Anyway, I assume this isn't so much a criticism of the fix as of the >>>> infrastructure around it. Correct? >>> >>> No, this is an objection to opening up devstat that way. >> >> Can you make an alternative suggestion? > >>>>> The right way to do it is probably to link the "struct disk"s >>>>> registered by the drivers with disk_creat() into a list which can >>>>> be searched. You're not very strong on reasoning here. You don't answer my question: >>>> Why should we maintain two lists, just because one is primarily >>>> intended for statistics? Your only objection appears to be: >>> No, this is an objection to opening up devstat that way. Devstat is already available in userland. What more opening up are you talking about? You approach appears to only add to kernel bloat. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000508083331.A61488>