Date: Wed, 6 Dec 2017 18:52:17 +0100 From: Kurt Jaeger <pi@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, hselasky@FreeBSD.org Subject: Re: svn commit: r455665 - head/audio/zynaddsubfx Message-ID: <20171206175217.GV68137@fc.opsec.eu> In-Reply-To: <20171206174407.GA82869@FreeBSD.org> References: <201712061730.vB6HU6hn021797@repo.freebsd.org> <20171206174407.GA82869@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > > Log: > > audio/zynaddsubfx: fix build on cur, 10.x by force llvm40 > > Commit message does not explain what was the original problem, so it's > hard to judge whether attempted solution is correct or not. Yes, as usual the saying goes: look at the PR, and you'll find the links to the build logs that failed. hps will probably dig into it if he finds time. > > @@ -41,8 +41,8 @@ GUI_LIB_DEPENDS= libfltk.so:x11-toolkits/fltk \ > > libfontconfig.so:x11-fonts/fontconfig > > GUI_ON= -DGuiModule:STRING=fltk > > GUI_CMAKE_OFF= -DGuiModule:STRING=OFF > > -GUI_USE+= XORG=x11,xext,xfixes,xcursor,ice,sm,xpm,xinerama,xft > > -GUI_USE+= GL=glu > > +GUI_USE+= XORG=x11,xext,xfixes,xcursor,xrender,ice,sm,xpm,xinerama,xft > > +GUI_USE+= GL=gl,glu > > This change was not explained in the commit log. It was missing, we found that during testbuilds, and added it as well. Would we add it if it would not be missing ? > > +.include <bsd.port.options.mk> > > What is this .include <bsd.port.options.mk> needed for? hps added it, and so it went in. I doubt it's necessary, so hps can remove it when he updates the port the next time. > > +# Build fix for ZynAddSubFx > > +BUILD_DEPENDS+= clang40:devel/llvm40 > > +CC= clang40 > > +CXX= clang++40 > > ./danfe -- pi@FreeBSD.org +49 171 3101372 3 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171206175217.GV68137>