Date: Sun, 8 Mar 1998 13:37:49 -0500 (EST) From: "John S. Dyson" <toor@dyson.iquest.net> To: bde@zeta.org.au (Bruce Evans) Cc: dyson@FreeBSD.ORG, gibbs@plutotech.com, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/miscfs/specfs spec_vnops.c Message-ID: <199803081837.NAA00266@dyson.iquest.net> In-Reply-To: <199803081829.FAA15021@godzilla.zeta.org.au> from Bruce Evans at "Mar 9, 98 05:29:06 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans said: > >> Modified files: > >> sys/miscfs/specfs spec_vnops.c > >> Log: > >> Initialize b_resid, and also print out better diagnostics on I/O > >> errors. This will allow for better tracking of user error reports. > > > >What is b_resid initialized to? CAM only touches b_resid when an error > >occurs or there is a residual, so I'm hoping it's initialized to 0. > >I think that other portions of the tree also expect it to be zero. > > It is initialized to 0. This is bogus since it is already initialized to > 0 (in initpbuf()). It might be useful to initialize it to a bad value to > punish portions of the tree expect it to be zero. It used to be abused > as the cylinder number for disksort(), so old code won't expect it to be > initialized. > We don't need to punish right now. Let's just try to stabilize, and where we have weaknesses, let's put appropriate diagnostics in the code. -- John | Never try to teach a pig to sing, dyson@freebsd.org | it just makes you look stupid, jdyson@nc.com | and it irritates the pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803081837.NAA00266>