Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 May 2002 10:18:38 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        Tony Finch <dot@dotat.at>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys gpt.h
Message-ID:  <20020530171838.GB308@dhcp01.pn.xcllnt.net>
In-Reply-To: <20020530103803.D10098@chiark.greenend.org.uk>
References:  <200205300544.g4U5iN586002@freefall.freebsd.org> <20020530094039.B10098@chiark.greenend.org.uk> <20020530103803.D10098@chiark.greenend.org.uk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 30, 2002 at 10:38:03AM +0100, Tony Finch wrote:
> 
> Actually, since you wouldn't have committed this without it getting the
> results you expected, I've done some more research and it looks like
> this is a C99 feature that gcc mis-implements, so you are depending on
> a gcc bug.

Sigh. Ok, I'll rip it out and add an explicit field of type uint32_t
to make the struct a multiple of 8 bytes. I'll change the CTASSERT
in geom_gpt.c to test for size 96 and I'll simply subtract the size
of the padding field from the value returned by sizeof() to get the
actual size I need to write into the header in the tool that creates
the GPT (not in the source tree). I think I was just avoiding to
have to do the latter.

Thanks for checking,

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020530171838.GB308>