Date: Thu, 17 May 2018 18:43:25 -0400 From: "John W. O'Brien" <john@saltant.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: Practice of "Sponsored by" in commit messages Message-ID: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> In-Reply-To: <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> References: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com> <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XzZylNZFp0InfREf4gwAdQEerniP8HJgr Content-Type: multipart/mixed; boundary="52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4"; protected-headers="v1" From: "John W. O'Brien" <john@saltant.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Message-ID: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> Subject: Re: Practice of "Sponsored by" in commit messages References: <ae2fe971-b20b-1fdf-48cd-58f595836c11@saltant.com> <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> In-Reply-To: <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> --52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018/05/14 20:14, Maxim Sobolev wrote: > What's wrong with a current practice. Why is it of any concern to you, > John? Just curious that is not very clear from your message. It is like= > someone trying to moderate what people in general or some group in > particular (e.g. freebsd committers) are allowed to put on their > t-shirts just because you find it offensive or inappropriate. I don't find crediting sponsors offensive nor inappropriate. Quite the contrary. What I find problematic is when multiple people do work, not all with sponsorship or the same sponsorship, and only one person's sponsor is mentioned in a way that seems to imply that all the work was sponsored. What I'm proposing is not to end or ban the practice, but to improve and refine it so that sponsors are credited for what they sponsor and not for what they don't sponsor. Is that clearer? > On Mon, May 14, 2018, 4:40 PM John W. O'Brien <john@saltant.com > <mailto:john@saltant.com>> wrote: >=20 > Hello FreeBSD Ports, >=20 > The Committer's Guide section on Commit Log Messages [0], doesn't c= over > the use of the "Sponsored by" key word. As a non-committer contribu= tor, > it only recently occurred to me to wonder what work that credit is > intended to represent, and whether some light definition would be > helpful to reduce ambiguity. >=20 > When a committer credits a sponsor of theirs, from which the contri= butor > received no sponsorship, the portrayal feels a little awkward. Does= this > strike the list as a problem, and if so, how ought it be solved? >=20 > To make this concrete, allow me to illustrate the situation. >=20 > Alice, working on her own time, prepares and contributes a patch. B= ob, > who works for Acme Corp, reviews and commits the patch on company t= ime. > The commit message includes "Sponsored by: Acme Corp". Alice eagerl= y > awaits her check from Acme Corp. Should the commit message have rea= d > "Sponsored by: Acme Corp (Bob)"? >=20 > This could be extensible to multiple sponsorships. If, instead, Ali= ce > prepares the patch having received a grant to do so from Best Sys D= ev, > the commit message could state "Sponsored by: Acme Corp (Bob), Best= Sys > Dev (Alice)". >=20 > [0] > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-gui= de/article.html#commit-log-message >=20 > PS: I realize that this issue transcends ports, but it's not clear = where > I should send this instead, and this list seems like it would have = a > reasonably high concentration of people with a stake in the discuss= ion. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --52Q63lRXW8gZSO3YM6fGEotGPUesvWJF4-- --XzZylNZFp0InfREf4gwAdQEerniP8HJgr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr+BY0ACgkQWPtK56pP /m4s3gf8CH5kAmx6Dy/eBgjZ37edsXFRoAfWe19dbuPnq1fU2V9dWrkW8uF7lhTJ tkRIXUjG6DgkJY9nOxDcBbOrp8noJh8eglERekAwzdfI20Y/QqqHj5MUYMwTRxfs O5BQGCHf1d3pk5JqrWJ7i9IamaPcRrGl3kwjPJpYhhiM0ZesDe7LbhiEBLViq+9P PJtQvBC/vpSxOprbsOO1gWEkiE5/iHRFxoSsAGM0tL5QsXbr347vi7oP/3dOzJ3W 56FA7PVY7d6I0K40Jl2EPUFNV7cGGHRnsFu5mB7EGqkniY/Y61zqpeEfVNEwOOul EKerY+HNSGigv0C00ileaFfKhi3YNg== =Syb7 -----END PGP SIGNATURE----- --XzZylNZFp0InfREf4gwAdQEerniP8HJgr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3cc77471-4200-1f45-e83d-2ae4d636f4fa>