Date: Sat, 15 Feb 2003 19:18:18 -0800 From: David Schultz <dschultz@uclink.Berkeley.EDU> To: Bruce Evans <bde@zeta.org.au> Cc: Alfred Perlstein <alfred@FreeBSD.ORG>, Sam Leffler <sam@errno.com>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <20030216031818.GA733@HAL9000.homeunix.com> In-Reply-To: <20030216122520.A20233-100000@gamplex.bde.org> References: <20030214214748.GA2520@HAL9000.homeunix.com> <20030216122520.A20233-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Bruce Evans <bde@zeta.org.au>: > On Fri, 14 Feb 2003, David Schultz wrote: > > A single extra space at the end of a line offends you? Some of > > It offends me if I look at the lines using something that is affected > by the spaces. > > > the ``style problems'' fixed by this commit aren't even in > > style(9). However, the following IS in style(9): ... > I know a bit about this problem since I have 100000 lines of local > patches (including 28000 lines in kern which have to be merged by > hand for almost every change). However, I like alfred's changes. > Even kern is becoming very ugly due to inconsistent styles. > Formatting changes are very easy to merge compared with semantic > changes unless they are done globally. Okay, you've got me beat. I guess I don't have quite as high standards as you and Alfred, nor do I use those wonderfully pedantic editing tools that display these stylistic solecisms in bright yellow. (They don't blink and beep too, do they? ;-) I work at various times on code in many styles in about half a dozen languages, so things I consider unreadable are more likely to include two-space indents and wrapped lines. I can see that I won't be able to argue with the status quo on this one, but I would still prefer it if people cut down on fixing the smaller nits, except in the vicinity of recent content changes. (Bruce, your practice of getting people to address these issues right away works great, I think.) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030216031818.GA733>