Date: Sat, 1 Dec 2001 15:51:09 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Maxime Henrion <mux@qualys.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c ip_input.c ip_var.h src/usr.bin/netstat inet.c Message-ID: <20011201155109.A45348@sunbay.com> In-Reply-To: <20011130205718.A275@nebula.noos.fr> References: <200111301040.fAUAeS519148@freefall.freebsd.org> <20011130205718.A275@nebula.noos.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 30, 2001 at 08:57:18PM +0100, Maxime Henrion wrote: > Ruslan Ermilov wrote: > > ru 2001/11/30 02:40:28 PST > > > > Modified files: > > sys/netinet icmp_var.h ip_icmp.c ip_input.c ip_var.h > > usr.bin/netstat inet.c > [...] > > This commit appears to break the kernel. In some cases, icmp_reflect() > calls icmp_send() with a NULL pointer for the struct route * parameter. > icmp_send() then pass it to ip_output() which dereferences it. > > I've had several panics like this at boot, and also got some lockups for > reasons I ignore. :-) > > It seems to me that in the icmp_reflect() code it is intentional to call > icmp_send() with a NULL pointer, so I did a little patch that use a > struct route bzero'ed in that case in icmp_send() as it was in revision > 1.63. It probably isn't a correct patch but at least it solved the > problem. > Fixed in ip_output,v 1.143. Sorry. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011201155109.A45348>