Date: Thu, 20 Sep 2018 14:24:33 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 218515] [NEW PORT] devel/naken_asm: Assembler/disassembler multiple CPUs Message-ID: <bug-218515-7788-IeTl4Jru8X@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-218515-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-218515-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218515 --- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> --- (In reply to mike from comment #2) XPORTVERSION=3D 2017.04.09 XDISTNAME=3D naken_asm-2017-04-09 Remove both and set DISTVERSION=3D 2017-04-09 instead. Probably could use an update to the newest version too. XPKGNAMEPREFIX=3D naken_asm- This will result in a package name of naken_asm-naken_asm which makes little sense. X#RUN_DEPENDS=3D libreadline.so:devel/readline Useless (and also wrong) comment. XGNU_CONFIGURE=3D yes Port does not use an autotools generated configure script, so it should be HAS_CONFIGURE instead. configure seems to use bash so it looks like there is a missing BUILD_DEPENDS for it here. X @mkdir -p ${STAGEDIR}${PREFIX} mkdir -p should be ${MKDIR}, but it's also unnecessary here. A stage directory and prefix skeleton is already created from /usr/ports/Templates/BSD.local.dist by the framework. X @cp ${WRKSRC}/naken_asm ${STAGEDIR}${PREFIX}/bin/ Never use cp in do-install. Use one of the INSTALL_* macros, here ${INSTALL_PROGRAM}. It'll make sure that the binaries have the right permissions and that they are stripped. XWWW: http://www.mikekohn.net/micro/naken_asm.php X X Superfluous new lines at the end of pkg-descr. X/usr/local/bin/naken_asm X/usr/local/bin/naken_util A two line pkg-plist should just be folded directly into PLIST_FILES in the Makefile. Also drop the /usr/local/ prefix here. PREFIX can be overridden by users and it's implied if the path is relative. Other issues: - Missing LICENSE and LICENSE_FILE - The port does not respect CFLAGS and LDFLAGS as set by the framework/users https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218515-7788-IeTl4Jru8X>