Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Mar 2017 10:09:02 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Pedro Giffuni <pfg@freebsd.org>
Cc:        FreeBSD-arch list <freebsd-arch@freebsd.org>
Subject:   Re: reallocarray(3) and its uses
Message-ID:  <CANCZdfpMZCcFkZptBFFpiw0vJrhwy-LZP9%2BJRSfXOCXzUDL=3g@mail.gmail.com>
In-Reply-To: <44f542e8-920f-c6bc-7eb0-2e4dab86a5eb@FreeBSD.org>
References:  <44f542e8-920f-c6bc-7eb0-2e4dab86a5eb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 10, 2017 at 10:00 AM, Pedro Giffuni <pfg@freebsd.org> wrote:
> Hello;
>
> I wasn't a fan of bringing reallocarray(3) from OpenBSD, but since we have
> it, I thought I'd take a look at using it. It is rather easy to use so I
> went around opengrok'ing "realloc" in userland and crosschecking with
> OpenBSD and I got to this patch:
>
> https://reviews.freebsd.org/D9915
>
> Current reviewers are mute: I am unsure if they are just deeply impressed
> and don't want to speak up or if they are simply too busy (most likely the
> later). There are still more uses in some utilities but I wanted to see what
> people think of the general idea.

https://www.youtube.com/watch?v=ussCHoQttyQ

Summarizes my view. I kinda like it since it helps on the overflow
front, but it's non standard so I kinda dislike it... I can make
arguments both ways and I can't decide which argument I like more...

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpMZCcFkZptBFFpiw0vJrhwy-LZP9%2BJRSfXOCXzUDL=3g>