Date: Sun, 08 Mar 1998 11:42:39 -0700 From: "Justin T. Gibbs" <gibbs@plutotech.com> To: "John S. Dyson" <toor@dyson.iquest.net> Cc: bde@zeta.org.au (Bruce Evans), dyson@FreeBSD.ORG, gibbs@plutotech.com, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/miscfs/specfs spec_vnops.c Message-ID: <199803081845.LAA19687@pluto.plutotech.com> In-Reply-To: Your message of "Sun, 08 Mar 1998 13:37:49 EST." <199803081837.NAA00266@dyson.iquest.net>
next in thread | previous in thread | raw e-mail | index | archive | help
>> >What is b_resid initialized to? CAM only touches b_resid when an error >> >occurs or there is a residual, so I'm hoping it's initialized to 0. >> >I think that other portions of the tree also expect it to be zero. >> >> It is initialized to 0. This is bogus since it is already initialized to >> 0 (in initpbuf()). It might be useful to initialize it to a bad value to >> punish portions of the tree expect it to be zero. It used to be abused >> as the cylinder number for disksort(), so old code won't expect it to be >> initialized. >> >We don't need to punish right now. Let's just try to stabilize, and where >we have weaknesses, let's put appropriate diagnostics in the code. So do you both believe that we should be setting b_resid always? I have no problem with this, it would simply be nice to have the semantics of the field clarified. All current upper level code seems to initialize it to zero... -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803081845.LAA19687>