Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Nov 1995 08:20:40 +0200
From:      Mark Murray <mark@grondar.za>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        asami@cs.berkeley.edu, CVS-commiters@freefall.freebsd.org, cvs-ports@freefall.freebsd.org, markm@freefall.freebsd.org
Subject:   Re: URGENT: Re: cvs commit: ports/security/pidentd/patches patch-ae 
Message-ID:  <199511220620.IAA26686@grumble.grondar.za>

next in thread | raw e-mail | index | archive | help
> In 2.1, <sys/sysctl.h> included <sys/ucred.h>.  Including <sys/ucred.h>
> doesn't work unless NGROUPS is already defined.  NGROUPS is a POSIX value
> that is defined in (a file included by) <limits.h>.  It also happens to
> be defined in (a file included by) <sys/param.h> and in <sys/syslimits.h>.
> 
> Mark apparently fixed a problem for 2.1 by removing <sys/sysctl.h>.  The
> correct fix was probably to include <limits.h> or <sys/param.h> or to
> complain until someone fixes <sys/ucred.h>.

Er, no. I fixed it for 2.2 by _adding_ #include <sys/sysctl.h>. I included
this file because I was having the same error as Satoshi below, and the
the only file that defined KERN_FILE was this one.

> >Hmm.  I tried it in my -current machine (made world from last night),
> >it fails at a different place. :<

This is where mine _used_ to fail until I put in the include.

> >>> make
> >Checksums OK.
> >===>  Configuring for pidentd-2.6.1
> >===>  Building for pidentd-2.6.1
> >Building for FreeBSD 2.x ...
> >cc -O2 -m486 -pipe -fno-strength-reduce -DFREEBSD  -DINCLUDE_EXTENSIONS -DHA
VE_KVM -c identd.c
> >cc -O2 -m486 -pipe -fno-strength-reduce -DFREEBSD  -DINCLUDE_EXTENSIONS -DHA
VE_KVM -c parse.c
> >cc -c -I. -O2 -m486 -pipe -fno-strength-reduce -DFREEBSD  -DINCLUDE_EXTENSIO
NS -DHAVE_KVM kernel/freebsd.c
> >kernel/freebsd.c: In function `k_getuid':
> >kernel/freebsd.c:215: `KERN_FILE' undeclared (first use this function)
> >kernel/freebsd.c:215: (Each undeclared identifier is reported only once
> >kernel/freebsd.c:215: for each function it appears in.)
> >*** Error code 1
> 
> KERN_FILE is defined in <sys/sysctl.h>.  <sys/sysctl.h> is not included by
> any other header.

Right!

M
--
Mark Murray
46 Harvey Rd, Claremont, Cape Town 7700, South Africa
+27 21 61-3768 GMT+0200
Finger mark@grumble.grondar.za for PGP key



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511220620.IAA26686>