Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jan 2008 14:05:15 +0000
From:      "Bruce M. Simpson" <bms@FreeBSD.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 133522 for review
Message-ID:  <4790B21B.3000102@FreeBSD.org>
In-Reply-To: <200801180525.m0I5PKss045795@repoman.freebsd.org>
References:  <200801180525.m0I5PKss045795@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=133522
>
> Change 133522 by imp@imp_paco-paco on 2008/01/18 05:25:09
>
> 	Prefer ${SHELL} to sh, since I like it.  Sadly, I got complaints
> 	when I proposed it for -current.
>   

The source of the objection might be that GNU make is known to prefer 
bash -- and I've torn my hair out on more than one occasion because of 
this behaviour.

However, buildenv is a target which explicitly forks an interactive 
shell, so the use of SHELL seems reasonable in this instance.

cheers
BMS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4790B21B.3000102>