Date: Wed, 11 Nov 2015 18:40:04 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r401299 - head/security/openssh-portable/files Message-ID: <5643FC04.4020001@FreeBSD.org> In-Reply-To: <20151112021225.GB43902@FreeBSD.org> References: <201511112121.tABLLjO6051679@repo.freebsd.org> <20151112021225.GB43902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/11/15 6:12 PM, Alexey Dokuchaev wrote: > On Wed, Nov 11, 2015 at 09:21:45PM +0000, Bryan Drewery wrote: >> New Revision: 401299 >> URL: https://svnweb.freebsd.org/changeset/ports/401299 >> >> Log: >> Make portlint stop spamming me. It's gotten quite silly. > > I hope this is a temporary measure, even though portlint(1) can indeed > get annoying at times. That said, I still don't see the problem with > simply ignoring warnings that do not apply in certain particular case. > >> WARN: /root/svn/ports/security/openssh-portable/files/patch-auth.c: >> patch was not generated using ``make makepatch''. It is recommended >> to use ``make makepatch'' when you need to [re-]generate a patch to >> ensure proper patch format. > > As John had said on IRC, this helps to get consistent patches, because > prople rarely think about these little details ("repo churn? who cares > about it") and portlint(1) warning gives them simple and straight course > of action. Yet it's true that the check could probably be made somewhat > smarter than simple grepping for "UTC". > > TL;DR: instead of adding noise to the patches, it's better to improve > portlint(1). Or learn how to ignore its warnings. ;-) > We should just ignore portlint at our own discretion since it grows stupid warnings like this? Mission accomplished? -- Regards, Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5643FC04.4020001>