Date: Sat, 16 Jun 2007 10:55:58 +0400 From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org> To: "Alexey Dokuchaev" <danfe@freebsd.org> Cc: cvs-ports@freebsd.org, pav@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/graphics/tcm Makefile pkg-message ports/graphics/tcm/files patch-debian-gcc4 pkg-message.in Message-ID: <cb5206420706152355p58660750h16803d72085be0c3@mail.gmail.com> In-Reply-To: <20070616063243.GA9047@FreeBSD.org> References: <200706152057.l5FKv26c070603@repoman.freebsd.org> <20070615210224.3C6A116A5D1@hub.freebsd.org> <cb5206420706151420i4c9f0a97q85ddf9b74d338bda@mail.gmail.com> <1181947632.52923.7.camel@ikaros.oook.cz> <cb5206420706152323m4215a8eay94a7d70b6225de2b@mail.gmail.com> <20070616063243.GA9047@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/16/07, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sat, Jun 16, 2007 at 10:23:09AM +0400, Andrew Pantyukhin wrote:
> > On 6/16/07, Pav Lucistnik <pav@freebsd.org> wrote:
> > >Andrew Pantyukhin p????e v so 16. 06. 2007 v 01:20 +0400:
> > >
> > >> > -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > >> > -PKGMESSAGE= ${WRKSRC}/pkg-message
> > >> > -USE_MOTIF= yes
> > >> > USE_BISON= yes
> > >> > USE_GMAKE= yes
> > >> > +USE_MOTIF= yes
> > >> > +
> > >> > +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > >> > +SUB_FILES+= pkg-message
> > >>
> > >> PKGMESSAGE defaults to PKGDIR/pkg-message. If we
> > >> have it processed with SUB_FILES, it will end up
> > >> in WRKDIR/pkg-message
> > >
> > >So? His usage of SUB_FILES is perfectly fine.
> >
> > What I can't seem to understand is why PKGMESSAGE is
> > changing from PKGDIR/pkg-message to WRKDIR/pkg-message
> > when SUB_FILES=pkg-message is defined.
>
> Probably because of this:
> bpm, around line 5554:
>
> .for i in pkg-message pkg-install pkg-deinstall pkg-req
> .if ${SUB_FILES:M${i}*}!=""
> ${i:S/-//:U}= ${WRKDIR}/${SUB_FILES:M${i}*}
> .endif
> .endfor
Hacky, but cool. Unfortunately it was never mentioned
in CHANGES, nor even in commit message (*wink at krion
and flz*). The only docs we have is ports/67151 and
code. Not that it requires any decoding, but a quick
grep discovers over 300 definitions of PKGMESSAGE which
were never needed (that's over a half of all pkg-message
preprocessing cases). So much for innovation.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420706152355p58660750h16803d72085be0c3>