Date: Sat, 15 Sep 2001 02:12:15 +0100 From: Brian Somers <brian@freebsd-services.com> To: obrien@FreeBSD.org Cc: Brian Somers <brian@freebsd-services.com>, Josef Karthauser <joe@tao.org.uk>, Garance A Drosihn <drosih@rpi.edu>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: Proposed patch to log_accum.pl Message-ID: <200109150112.f8F1CFd39815@hak.lan.Awfulhak.org> In-Reply-To: Message from "David O'Brien" <obrien@FreeBSD.org> of "Fri, 14 Sep 2001 14:09:12 PDT." <20010914140912.B98219@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Sep 14, 2001 at 10:29:51AM +0100, Brian Somers wrote:
> > > Revision Changes Path
> > > 1.108 +6 -5 src/sys/kern/kern_descrip.c
> > > 1.1 +123 X src/sys/kern/new_file.c (new)
> > > 1.234 X -669 src/sys/kern/dead_file.c (attic)
> > >
> > > or some other character to pad the column out, but to indicate that
> > > there's no value there?
> >
> > Hmm, I think the X looks odd.
> >
> > If we have (new) and (attic) then we don't need the Xs. If we have
> > the Xs (or even if we have nothing) we don't need the (new) or
> > (attic).
> >
> > Personally I prefer my original suggestion on the basis that it has
> > no duplicated information. Parsing is easy, but not as easy as
> > having a pad character.
>
> I assume you'll be fixing the `cvsmail' port then? :-)
It doesn't seem to be marked broken here :*P
> --
> -- David (obrien@FreeBSD.org)
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109150112.f8F1CFd39815>