Date: Thu, 10 Feb 2005 12:50:03 +0100 (CET) From: Michael Nottebrock <michaelnottebrock@gmx.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/77344: bsd.port.mk misses checks for USE_PYTHON_(BUILD|RUN) Message-ID: <200502101150.j1ABo3eW010461@kiste.my.domain> Resent-Message-ID: <200502101210.j1ACAP2K097201@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 77344
>Category: ports
>Synopsis: bsd.port.mk misses checks for USE_PYTHON_(BUILD|RUN)
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 10 12:10:25 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Michael Nottebrock
>Release: FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD kiste 5.3-STABLE FreeBSD 5.3-STABLE #1: Wed Feb 9 18:43:46 CET 2005 root@kiste:/usr/obj/usr/src/sys/KISTE-UP i386
>Description:
bsd.python.mk implements the USE_PYTHON, USE_PYTHON_BUILD and USE_PYTHON_RUN
switches. The two latter only trigger runtime/buildtime dependencies, while
USE_PYTHON entails both.
bsd.port.mk however only checks for USE_PYTHON and does not include bsd.python.mk
if USE_PYTHON_BUILD or USE_PYTHON_RUN are set, thus making those switches effec-
tively unavailable to potential users.
>How-To-Repeat:
>Fix:
--- bpm.diff begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.509
diff -u -r1.509 bsd.port.mk
--- bsd.port.mk 9 Feb 2005 09:07:37 -0000 1.509
+++ bsd.port.mk 10 Feb 2005 11:41:58 -0000
@@ -1300,7 +1300,7 @@
.include "${PORTSDIR}/Mk/bsd.php.mk"
.endif
-.if defined(USE_PYTHON)
+.if defined(USE_PYTHON) || defined(USE_PYTHON_BUILD) || defined(USE_PYTHON_RUN)
.include "${PORTSDIR}/Mk/bsd.python.mk"
.endif
--- bpm.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502101150.j1ABo3eW010461>