Date: Thu, 19 Jul 2018 20:32:55 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Cy Schubert <cy@freebsd.org>, "Oleg V. Nauman" <oleg@theweb.org.ua>, Cy Schubert <Cy.Schubert@cschubert.com> Subject: Re: svn commit: r336203 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/patches contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers c... Message-ID: <20180720003255.6dglwhbrnyewowdh@mutt-hbsd> In-Reply-To: <CACNAnaHFyB5FdWVpd3jOa5rpDtBdEm3Z0%2Bsx6jb_nXj8mQ5=CQ@mail.gmail.com> References: <Cy.Schubert@cschubert.com> <201807192114.w6JLEapA097589@slippy.cwsent.com> <201807192133.w6JLXRX4066519@slippy.cwsent.com> <CACNAnaHqg%2BaE7xyeq30egw5sEWYrcsF9T4hv=U7Qmh38jXcFwQ@mail.gmail.com> <CACNAnaHFyB5FdWVpd3jOa5rpDtBdEm3Z0%2Bsx6jb_nXj8mQ5=CQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--bvk5gnc4ixttbtgj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 19, 2018 at 07:24:46PM -0500, Kyle Evans wrote: > On Thu, Jul 19, 2018 at 6:21 PM, Kyle Evans <kevans@freebsd.org> wrote: > > On Thu, Jul 19, 2018 at 4:33 PM, Cy Schubert <Cy.Schubert@cschubert.com= > wrote: > >> In message <201807192114.w6JLEapA097589@slippy.cwsent.com>, Cy Schubert > >> writes: > >>> In message <17042686.Mc0X0P6XHu@asus.theweb.org.ua>, "Oleg V. Nauman" > >>> writes: > >>> > On Thursday, July 19, 2018 4:54:42 PM EEST Cy Schubert wrote: > >>> > > In message <CACNAnaEaMtRfHTXyCcGGmVP_37=3DgjLfDjPD5yd1gZqmpC0Z0Rg= @mail.gma > >>> > > il.com> > >>> > > > >>> > > , Kyle Evans writes: > >>> > > > On Thu, Jul 19, 2018 at 7:13 AM, Niclas Zeising > >>> > > > > >>> > > > <zeising+freebsd@daemonic.se> wrote: > >>> > > > > [ sending this again since I missed the list the first time, = apologie > >>> s > >>> > > > > if > >>> > > > > anyone receives a duplicate ] > >>> > > > > > >>> > > > > On 07/19/18 13:57, Kyle Evans wrote: > >>> > > > >> On Thu, Jul 19, 2018 at 4:51 AM, Alexey Dokuchaev <danfe@fre= ebsd.org > >>> > > >>> > > > >> > >>> > > > >> wrote: > >>> > > > >>> On Thu, Jul 19, 2018 at 11:48:03AM +0300, Andrey V. Elsukov= wrote: > >>> > > > >>>> ... > >>> > > > >>>> Yesterday I updated my notebook (with iwm(4)) and also not= iced tha > >>> t > >>> > > > >>>> wi-fi connection periodically breaks. /etc/rc.d/wpa_suppli= cant > >>> > > > >>>> restart > >>> > > > >>>> wlan0 helps. After your message I reinstalled wpa_supplica= nt from > >>> ol > >>> > d > >>> > > > >>>> source and now it works stable already about 2 hours. > >>> > > > >>> > >>> > > > >>> So, right now, we have broken wpa_supplicant(8) in -CURRENT= ? :-/ > >>> > > > >> > >>> > > > >> Well, "broken". It's incredibly stable outside of rekeying e= vents, a > >>> nd > >>> > > > >> further testing shows that I don't actually notice these dis= connects > >>> > > > >> most of the time because it reassociates fast enough. I noti= ced it t > >>> he > >>> > > > >> first time because apparently I had both SSIDs from my AP un= commente > >>> d > >>> > > > >> in my wpa_supplicant.conf and it decided at that point to co= nnect to > >>> > > > >> the other one, which took a little longer. > >>> > > > >> > >>> > > > >> Contrary to Andrey's report, though, I don't have to kick > >>> > > > >> wpa_supplicant at all. It will reassociate on its own every = single > >>> > > > >> time. > >>> > > > > > >>> > > > > Hi! > >>> > > > > I have the exact same problem as Andrey, with the same driver= =2E I've > >>> no > >>> > t > >>> > > > > investigated very much, but when using the 2.8 wpa_supplicant= the wif > >>> i > >>> > > > > network dies after a little while, and I have to restart it (= usually > >>> > > > > with > >>> > > > > /etc/rc.d/netif restart). Then it works for a little while, = before > >>> > > > > going > >>> > > > > down again. With the old wpa_supplicant I didn't have this p= roblem. > >>> > > > > > >>> > > > > I don't have very much else to add except noting that I'm aff= ected as > >>> > > > > well. > >>> > > > > I haven't had time to debug it properly (which is why I've ne= ver > >>> > > > > reported > >>> > > > > it) > >>> > > > > >>> > > > I plan on trying out the latest from upstream beyond the patch = Cy sent > >>> > > > along earlier to see if it's perhaps been addressed elsewhere i= n the > >>> > > > past two years since this release was made. > >>> > > > >>> > > A point of reference. I've had no issues here with any of the net= works > >>> > > I use. All the networks I use are either WPA-PSK or open. The last > >>> > > WPA-EAP I used was at former $JOB a few years ago. However, at th= e Link > >>> > > Lounge just outside where $JOB is at my wifi would disconnect eve= ry 30 > >>> > > minutes using our old wpa 2.5, requiring a netif restart. 2.6 res= olved > >>> > > that issue. > >>> > > > >>> > > Upline git commit 0adc9b28b39d414d5febfff752f6a1576f785c85 also l= ooks > >>> > > interesting. > >>> > > > >>> > > ommit 0adc9b28b39d414d5febfff752f6a1576f785c85 > >>> > > Author: Jouni Malinen <j@w1.fi> > >>> > > Date: Sun Oct 1 12:32:57 2017 +0300 > >>> > > > >>> > > Fix PTK rekeying to generate a new ANonce > >>> > > > >>> > > The Authenticator state machine path for PTK rekeying ended up > >>> > > bypassing > >>> > > the AUTHENTICATION2 state where a new ANonce is generated whe= n going > >>> > > directly to the PTKSTART state since there is no need to try = to > >>> > > determine the PMK again in such a case. This is far from ideal > >>> > > since the > >>> > > new PTK would depend on a new nonce only from the supplicant. > >>> > > > >>> > > Fix this by generating a new ANonce when moving to the PTKSTA= RT > >>> > > state > >>> > > for the purpose of starting new 4-way handshake to rekey PTK. > >>> > > > >>> > > Signed-off-by: Jouni Malinen <j@w1.fi> > >>> > > > >>> > > > >>> > > I suspect a timeout because reason=3D1 in Kyle's log. > >>> > > >>> > > >>> > I have two systems experienced wifi connection issues after recent= HEAD > >>> > update. > >>> > Both of them experiencing frequent up/down wlan0 events on boot so= wireles > >>> s > >>> > connection can not negotiate DHCP requests, possibly due to fact th= at both > >>> > connecting to the same AP. > >>> > AP capabilities list: > >>> > > >>> > ***** f8:1a:67:56:16:16 1 54M -74:-96 100 EPS WPA WME AT= H WPS > >>> > > >>> > Interesting enough that switching wpa_supplicant to version 2.6 fro= m ports > >>> > fixes that issue completely. > >>> > > >>> > Hopefully it helps. > >>> > > >>> > Thank you. > >>> > >>> I've imported all the patches in the port, from our upline into base. > >>> Some were already committed to > >>> -- > >>> Cheers, > >>> Cy Schubert <Cy.Schubert@cschubert.com> > >>> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org > >>> > >>> The need of the many outweighs the greed of the few. > >>> base 2.5 others not. This should bring base up to par with the port, > >>> address the remaining security issues, and probably fix this thread t= oo. > >> > >> exmh. I had my cursor in the wrong place when I hit send. > >> > >> I've imported all the patches in the port, from our upline into base. > >> Some were already committed to base 2.5 others not. This should bring > >> base up to par with the port, address the remaining security issues, > >> and probably fix this thread too. > >> > > > > FWIW- with ports 2.6 I've confirmed that instead of the reassociation I= get: > > > > Jul 19 18:17:30 shiva wpa_supplicant[34199]: wlan0: WPA: Group > > rekeying completed with ... [GTK=3DCCMP] > > > > I'll try with base 2.6 now that you've updated with all of these patche= s. >=20 > Alright, base 2.6 is still no good here. I note that there's still > some diff between ports and base [1] (about 252 lines of diff to sort > through, nothing serious... I removed the obviously-for-libressl > diff). >=20 > Some of it looks kind of suspicious, but I'd guess the changes in > ./src/rsn_supp/wpa.c are mostly what make the difference for me. How > much of this really needs to stick around, given that ports > wpa_supplicant is actually pretty stable? (Attempting to read between the lines, forgive me if I misinterpreted.) Some of the systems I've set up recently are more easily set up with wireless. Running a 100ft cable in an office building isn't that fun. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --bvk5gnc4ixttbtgj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAltRLbIACgkQaoRlj1JF bu4LrQ//S/++VBsLDBqvlv61VfI498aW8GGHPtPMvy11yQnPi5y7sRFRjO1U9q6+ 7GKiBlSNAmFxr8ycblWyvAqzs46H3KlwKBIdquBnc+A+sdQj2KaheUEBIuw1bEPd GQ0lqwb9CxJjMDm8TSThmeNgWxtzS1wQNpuc36PuszQvLUwRYHeVphYUeBYUPo9P Ao4C5gB7GVOoJ8quYtoi+XMXOyPkQKO8f2v4tto+GSgulxWC8/UrD7Oy/87GGxbN cIrIDp6+d1tdnz+q5CEo8ib5J6Nex79ENs4Z3hvfGyWz/9LLk6VQxRNdN0K/m1Vr pnJTD37gtwCVnGYs2I9jSkHJV8JTiulRA7ZZiaC5ZQU7rFAFCymx9qdk6+jkPdHi zSbQdoC/J2yEhzMhX39/BKAfgJpOfwtNIn0bszb1mG753aXdrFyDK0rPM7e1hb+Q sWKnBYgjUmMQs01AYMC3gIpy1fZbMgDWA+bCHwQeRloRbFe97E1kA5woIZpxq0jP 4S0Ruuy0QmJat9v+ZRtCqbarHDZXSorC5xPDc414XNyVo9gbH5G856a3ggNxtJfx 8wJVylTDXuNgEhI4J2sAJG7OrUxKRbGoNBsU0IYyWuFdX+tkhvHDn/dcG+3Di+kD sSuFPmWQR9Ret9nSECeWfjBMTbp5/kzgpVO8VRo+NM+fL8FSG3g= =HiYc -----END PGP SIGNATURE----- --bvk5gnc4ixttbtgj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180720003255.6dglwhbrnyewowdh>