Date: Wed, 5 Mar 2008 20:33:30 +0100 From: Roman Divacky <rdivacky@freebsd.org> To: Jeff Roberson <jroberson@chesapeake.net> Cc: emulation@freebsd.org, jeff@freebsd.org Subject: Re: [PATCH] linux get affinity syscall Message-ID: <20080305193330.GA18756@freebsd.org> In-Reply-To: <20080304155205.X920@desktop> References: <20080302110130.GA30563@freebsd.org> <20080303022202.S920@desktop> <20080303144152.GA47887@freebsd.org> <20080303121025.K920@desktop> <20080304155205.X920@desktop>
next in thread | previous in thread | raw e-mail | index | archive | help
--SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >>>> if (args->len < sizeof(cpumask_t)) > >>>> return (EINVAL); >=20 > This should not be necessary anymore. >=20 > >>> > >>>Len here is in number of bits I believe as it is for our cpusetsize. > >> > >>no.. its specified in bytes > > > >You are right. So it is with fdsets. Please hold on and I'll change=20 > >cpuset to be bytes as well. > > > >> > >>>> > >>>> cga.level =3D CPU_LEVEL_WHICH; > >>>> cga.which =3D CPU_WHICH_PID; > >>>> cga.id =3D args->pid; > >>>> cga.cpusetsize =3D sizeof(cpumask_t) * NBBY; > >>>> cga.mask =3D (long *) args->user_mask_ptr; > >>> >=20 > I checked in a change to make our cpusetsize compatible. You should only= =20 > have to supply CPU_LEVEL_WHICH and CPU_WHICH_PID now. The rest of the=20 > arguments are compatible. is it possible to make cpuset_setproc non-static? if so could you please review the following patch: www.vlakno.cz/~rdivacky/linux_affinity.patch and tell me if its ok? (it lacks #include of something that should contain the prototype for cpuset_setproc()) thnx, roman --SUOF0GtieIMvvwua Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) iEYEARECAAYFAkfO9YoACgkQLVEj6D3CBEw1QwCfRyMTnaslDncJpTG8ppSZX/5U N2oAoILXqNN2kadGrAaON8GY+gWq8nxJ =9Uz2 -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080305193330.GA18756>