Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 Sep 2010 16:06:01 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r212209 - head/sys/netinet
Message-ID:  <201009041606.o84G61Ht020773@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bz
Date: Sat Sep  4 16:06:01 2010
New Revision: 212209
URL: http://svn.freebsd.org/changeset/base/212209

Log:
  In case of RADIX_MPATH do not leak the IN_IFADDR read lock on
  early return.
  
  MFC after:	3 days

Modified:
  head/sys/netinet/in.c

Modified: head/sys/netinet/in.c
==============================================================================
--- head/sys/netinet/in.c	Sat Sep  4 13:13:00 2010	(r212208)
+++ head/sys/netinet/in.c	Sat Sep  4 16:06:01 2010	(r212209)
@@ -1039,9 +1039,10 @@ in_addprefix(struct in_ifaddr *target, i
 		if (ia->ia_flags & IFA_ROUTE) {
 #ifdef RADIX_MPATH
 			if (ia->ia_addr.sin_addr.s_addr == 
-			    target->ia_addr.sin_addr.s_addr)
+			    target->ia_addr.sin_addr.s_addr) {
+				IN_IFADDR_RUNLOCK();
 				return (EEXIST);
-			else
+			} else
 				break;
 #endif
 			if (V_sameprefixcarponly &&



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009041606.o84G61Ht020773>