Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 May 2013 17:55:01 +0200
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r318663 - head/Mk
Message-ID:  <20130521155501.GG20911@gahrfit.gahr.ch>
In-Reply-To: <519B95F3.6030901@FreeBSD.org>
References:  <201305210859.r4L8x3qi001432@svn.freebsd.org> <519B95F3.6030901@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--idY8LE8SD6/8DnRI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2013-May-21, 10:42, Bryan Drewery wrote:
> On 5/21/2013 3:59 AM, Pietro Cerutti wrote:
> > Author: gahr
> > Date: Tue May 21 08:59:02 2013
> > New Revision: 318663
> > URL: http://svnweb.freebsd.org/changeset/ports/318663
> >=20
> > Log:
> >   - Switch default version of Tcl/Tk from 8.5 to 8.6
> >  =20
> >   PR:		178369
> >   Submitted by:	gahr
> >   Approved by:	portmgr (after exp-run)
> >=20
> > Modified:
> >   head/Mk/bsd.tcl.mk
> >=20
> > Modified: head/Mk/bsd.tcl.mk
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/Mk/bsd.tcl.mk	Tue May 21 08:56:40 2013	(r318662)
> > +++ head/Mk/bsd.tcl.mk	Tue May 21 08:59:02 2013	(r318663)
> > @@ -13,7 +13,7 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
> >  #			  via the port or by the user via defined variable try to find the=
 highest
> >  #			  stable installed version.
> >  #			  Available values: yes 86+ 85+ 84+ 85 84
> > -#			  NOTE: - default value 85 is used in case of USE_TCL=3Dyes
> > +#			  NOTE: - default value 86 is used in case of USE_TCL=3Dyes
> >  #
> >  # USE_TCL_BUILD		- Add buildtime dependency on Tcl (tclsh).
> >  #			  Available values: see USE_TCL
> > @@ -28,12 +28,12 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
> >  #			  a specific tclsh version may use this.
> >  #			  The tclsh wrapper script installs into ${LOCALBASE}/bin/tclsh
> >  #			  NOTE: - USE_TCL_WRAPPER and USE_TCL can be used together
> > -#			        - ports using the wrapper should support default Tcl (8.5)
> > +#			        - ports using the wrapper should support default Tcl (8.6)
> >  ##
> >  # INVALID_TCL_VER	- This variable contains a list of Tcl versions not =
supported by the port.
> > -#			  This setting is effective only when USE_TCL is set to a range (e=
=2Eg. 84+)
> > +#			  This setting is effective only when USE_TCL is set to a range (e=
=2Eg. 85+)
> >  # WITH_TCL_VER		- User defined global variable to set Tcl version
> > -#			  This variable is effective only if USE_TCL is set to a range (e.=
g. 84+)
> > +#			  This variable is effective only if USE_TCL is set to a range (e.=
g. 85+)
> >  #			  and WITH_TCL_VER points inside that range.
> >  #			  NOTE: INVALID_TCL_VER takes precedence
> >  # <UNIQUENAME>_WITH_TCL_VER	- User defined port specific variable to s=
et Tcl version
> > @@ -46,7 +46,7 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
> >  #			  stable installed version.
> >  #			  Avaliable values: yes 86+ 85+ 84+ 85 84
> >  #			  NOTE: - overrides USE_TCL
> > -#			        - default value 85 is used in case of USE_TK=3Dyes
> > +#			        - default value 86 is used in case of USE_TK=3Dyes
> >  #
> >  # USE_TK_BUILD		- Add buildtime dependency on Tk (wish).
> >  #			  Available values: see USE_TK
> > @@ -61,12 +61,12 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
> >  #			  a specific wish version may use this.
> >  #			  The wish wrapper script installs into ${LOCALBASE}/bin/wish
> >  #			  NOTE: - USE_TK_WRAPPER and USE_TK can be used together.
> > -#			        - ports using the wrapper should support default Tk (8.5)
> > +#			        - ports using the wrapper should support default Tk (8.6)
> >  ##
> >  # INVALID_TK_VER	- This variable contains a list of Tk versions not su=
pported by the port
> > -#			  This setting is effective only when USE_TK is set to a range (e.=
g. 84+)
> > +#			  This setting is effective only when USE_TK is set to a range (e.=
g. 85+)
> >  # WITH_TK_VER		- User defined global variable to set Tk version.
> > -#			  This variable is effective only if USE_TK is set to a range (e.g=
=2E 84+)
> > +#			  This variable is effective only if USE_TK is set to a range (e.g=
=2E 85+)
> >  #			  and WITH_TK_VER points inside that range.
> >  #			  NOTE: overrides WITH_TCL_VER.
> >  # <UNIQUENAME>_WITH_TK_VER	- User defined port specific variable to se=
t Tk version
> > @@ -157,7 +157,7 @@ INVALID_TCL_VER:=3D	${INVALID_TK_VER}
> >  #
> >  . if defined(USE_TCL)
> > =20
> > -_TCL_DEFAULT_VERSION=3D		85
> > +_TCL_DEFAULT_VERSION=3D		86
>=20
> Would you consider adding TCL_DEFAULT_VERSION?=3D 86 instead? I would like
> to default to 85 still on my systems.

Can't you use WITH_TCL_VER / WITH_TK_VER for that?


--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--idY8LE8SD6/8DnRI
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlGbmNQACgkQwMJqmJVx945aQgCcDR3PhIaPnPgemwsl97gDlAAO
gskAnRNuIjUOiMoOfHQQdRWCWou9Zt6G
=1Y6r
-----END PGP SIGNATURE-----

--idY8LE8SD6/8DnRI--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130521155501.GG20911>