Date: Sun, 4 Sep 2011 06:03:19 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Philippe Audeoud <jadawin@freebsd.org>, Brendan Fabeny <bf1783@gmail.com> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/finance/quantlib Makefile distinfo pkg-plist Message-ID: <alpine.LNX.2.00.1109040549550.4335@gerinyyl.fvgr> In-Reply-To: <BANLkTimr3O_Dt2OqCkCcPQ1YduBdLtSGYg@mail.gmail.com> References: <201105301136.p4UBaOg9066272@repoman.freebsd.org> <BANLkTimr3O_Dt2OqCkCcPQ1YduBdLtSGYg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 30 May 2011, b. f. wrote: > CPPFLAGS is now added to MAKE_ENV in bsd.port.mk, so it is unnecessary > to add it here, in the port Makefile. I'm not sure why portlint warns > about this addition in the case of CONFIGURE_ENV, but not MAKE_ENV. > The original request for this warning, > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155550 > > , asked for checks in both cases. Philippe, I see you did not make the change Brendan asked for; may I apply the patch below? Brendan, as for your observation, I just filed PR/160448. Gerald Index: Makefile =================================================================== RCS file: /home/pcvs/ports/finance/quantlib/Makefile,v retrieving revision 1.32 diff -u -r1.32 Makefile --- Makefile 30 May 2011 11:36:24 -0000 1.32 +++ Makefile 4 Sep 2011 03:49:52 -0000 @@ -23,7 +23,7 @@ GNU_CONFIGURE= yes CPPFLAGS= ${PTHREAD_CFLAGS} -I${LOCALBASE}/include LDFLAGS= ${PTHREAD_LIBS} -L${LOCALBASE}/lib -MAKE_ENV= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" +MAKE_ENV= LDFLAGS="${LDFLAGS}" USE_LDCONFIG= yes MAN1= quantlib-config.1 quantlib-test-suite.1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1109040549550.4335>