Date: Sat, 28 Sep 2002 19:36:58 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make main.c Message-ID: <20020928193658.A90200@FreeBSD.org> In-Reply-To: <20020929122637.P39746-100000@gamplex.bde.org>; from bde@zeta.org.au on Sun, Sep 29, 2002 at 12:40:05PM %2B1000 References: <200209290002.g8T025P0072694@freefall.freebsd.org> <20020929122637.P39746-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: Bruce Evans <bde@zeta.org.au> [ Data: 2002-09-28 ] [ Subjecte: Re: cvs commit: src/usr.bin/make main.c ] > On Sat, 28 Sep 2002, Juli Mallett wrote: > > > jmallett 2002/09/28 17:02:05 PDT > > > > Modified files: > > usr.bin/make main.c > > Log: > > Fix ability to use csh(1) as the make(1) shell. > > > > Sponsored by: Bright Path Solutions > > > > Revision Changes Path > > 1.73 +3 -1 src/usr.bin/make/main.c > > Shouldn't this be -1 +3 to remove any such ability, since such ability is > a bug? :-) > > The most interesting aspects of using wrong shells for make(1) don't seem > to have been addressed: > - POSIX requires the shell to be the standard one and doesn't permit the > environment variable SHELL to affect this; it requires unusual handlng > of SHELL which isn't implemented. > - make(1)'s .SHELL variable provides much more powerful foot-shooting than > the MAKE_SHELL hack, except at least the documented example of using it > doesn't actually work (see the tutorial for the documentation). job.c allowed MAKE_SHELL to imply csh, the Makefile does, but main.c didn't. Call it fixing consistency for this existing bug :) -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020928193658.A90200>