Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Nov 2017 08:56:22 -0800
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Hans Petter Selasky <hselasky@FreeBSD.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   Re: svn commit: r325894 - projects/bsd_rdma_4_9
Message-ID:  <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org>
In-Reply-To: <201711161513.vAGFDThx060235@repo.freebsd.org>
References:  <201711161513.vAGFDThx060235@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3
Content-Type: multipart/mixed; boundary="dJq4P30mqlfkK6aGe015IRAkmqUViwOwb";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-projects@freebsd.org
Message-ID: <a46a9d84-eb10-0fcf-9312-983dad229a4c@FreeBSD.org>
Subject: Re: svn commit: r325894 - projects/bsd_rdma_4_9
References: <201711161513.vAGFDThx060235@repo.freebsd.org>
In-Reply-To: <201711161513.vAGFDThx060235@repo.freebsd.org>

--dJq4P30mqlfkK6aGe015IRAkmqUViwOwb
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 11/16/2017 7:13 AM, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Thu Nov 16 15:13:28 2017
> New Revision: 325894
> URL: https://svnweb.freebsd.org/changeset/base/325894
>=20
> Log:
>   Update list of hardcoded OFED build order dependencies for
>   the buildworld target.
>  =20
>   Sponsored by:	Mellanox Technologies
>=20
> Modified:
>   projects/bsd_rdma_4_9/Makefile.inc1
>=20
> Modified: projects/bsd_rdma_4_9/Makefile.inc1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- projects/bsd_rdma_4_9/Makefile.inc1	Thu Nov 16 14:37:18 2017	(r3258=
93)
> +++ projects/bsd_rdma_4_9/Makefile.inc1	Thu Nov 16 15:13:28 2017	(r3258=
94)
> @@ -2410,16 +2410,33 @@ _lib_libradius=3D	lib/libradius
>  .endif
> =20
>  .if ${MK_OFED} !=3D "no"
> -_ofed_lib=3D		contrib/ofed/usr.lib
> -_prebuild_libs+=3D	contrib/ofed/usr.lib/libosmcomp
> -_prebuild_libs+=3D	contrib/ofed/usr.lib/libopensm
> -_prebuild_libs+=3D	contrib/ofed/usr.lib/libibcommon
> -_prebuild_libs+=3D	contrib/ofed/usr.lib/libibverbs
> -_prebuild_libs+=3D	contrib/ofed/usr.lib/libibumad
> +_ofed_lib=3D \
> +contrib/ofed/include \
> +contrib/ofed/libcxgb4 \
> +contrib/ofed/libibcm \
> +contrib/ofed/libibmad \
> +contrib/ofed/libibnetdisc \
> +contrib/ofed/libibumad \
> +contrib/ofed/libibverbs \
> +contrib/ofed/libmlx4 \
> +contrib/ofed/libmlx5 \
> +contrib/ofed/librdmacm \
> +contrib/ofed/opensm/complib \
> +contrib/ofed/opensm/libopensm \
> +contrib/ofed/opensm/libvendor
> =20
> -contrib/ofed/usr.lib/libopensm__L: lib/libthr__L
> -contrib/ofed/usr.lib/libosmcomp__L: lib/libthr__L
> -contrib/ofed/usr.lib/libibumad__L: contrib/ofed/usr.lib/libibcommon__L=

> +contrib/ofed/libcxgb4__L: contrib/ofed/libibverbs__L lib/libthr__L con=
trib/ofed/include__L
> +contrib/ofed/libibcm__L: contrib/ofed/libibverbs__L contrib/ofed/inclu=
de__L
> +contrib/ofed/libibmad__L: contrib/ofed/libibumad__L contrib/ofed/inclu=
de__L
> +contrib/ofed/libibnetdisc__L: contrib/ofed/opensm/complib__L contrib/o=
fed/libibmad__L contrib/ofed/libibumad__L contrib/ofed/include__L
> +contrib/ofed/libibumad__L: contrib/ofed/include__L
> +contrib/ofed/libibverbs__L: contrib/ofed/include__L
> +contrib/ofed/libmlx4__L: contrib/ofed/libibverbs__L lib/libthr__L cont=
rib/ofed/include__L
> +contrib/ofed/libmlx5__L: contrib/ofed/libibverbs__L lib/libthr__L cont=
rib/ofed/include__L
> +contrib/ofed/librdmacm__L: contrib/ofed/libibverbs__L contrib/ofed/inc=
lude__L
> +contrib/ofed/opensm/complib__L: lib/libthr__L contrib/ofed/include__L
> +contrib/ofed/opensm/libopensm__L: lib/libthr__L contrib/ofed/include__=
L
> +contrib/ofed/opensm/libvendor__L: contrib/ofed/libibumad__L lib/libthr=
__L contrib/ofed/include__L
>  .endif
> =20
>  .if ${MK_CASPER} !=3D "no"
>=20

This isn't right, you don't need to include any 'include' directories in
here as 'make includes' is ran before 'make libraries'.

You don't need libthr either as it is in prebuild_libs which is built
before all of this.

I suspect the actual change needed is far smaller than this.

--=20
Regards,
Bryan Drewery


--dJq4P30mqlfkK6aGe015IRAkmqUViwOwb--

--dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJaDcM2AAoJEDXXcbtuRpfPi78H/12XZ98CiMwnWr+OmLK4IUot
KSgM/IDA3BJyHm4l2zYDYVn9IepddjArEyHy+l1hchfj/V5dTqA7RKGM5XitAPIh
jUkbn9GdRvZnW4ar5hYDcEideIQXgyNx9H4Eq/ZcvE+XTLXir8wbnZ9oVV8xYmEK
hqtyWeqcDVEp/qxe8gM9Sr+UX66MAGsdRX5gHfN4NVr235h7R1Xi4VJo+LPkctyl
tnaX3fnQpJCpxJGh9HoR6Yc+/DlfZU8ZE3AYB0hky37QVAdC9J2rnXev8c0hQGP6
Ewv0dTzVcWryMc8p8LSQbdHkgARVLpOPksBEwVIYu2TLmHJjfqjpc4WbcBZf76U=
=jnWK
-----END PGP SIGNATURE-----

--dFiqTsRV5R13CqOuqpq5ibB9BMr6U9Re3--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a46a9d84-eb10-0fcf-9312-983dad229a4c>