Date: Wed, 18 May 2005 07:19:15 -0700 (PDT) From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/81203: mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS Message-ID: <200505181419.j4IEJFSl012559@pentarou.parodius.com> Resent-Message-ID: <200505181420.j4IEK21P010384@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 81203 >Category: ports >Synopsis: mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed May 18 14:20:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.11-STABLE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Thu May 12 04:37:52 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: The addition of the MUTT_LITE knob is fantastic; however, use of this knob no longer allows an administrator to build a "lite" version of mutt _with_ support for multiple character sets (such as on our systems). I propose the WITHOUT_NLS=yes definition inside of the MUTT_LITE knob be removed; administrators can then say MUTT_LITE=true WITHOUT_NLS=true when building, which is consistent with nearly every other port in ports. I must stress this point, since MUTT_LITE breaks the "norm" in this respect. Most administrators who do not want multiple character set support define WITHOUT_NLS=true in /etc/make.conf anyways, i.e. every port on the system will not use iconv/gettext. :-) Either way, it's up for discussion. The port maintainer should be the one to make the call. >How-To-Repeat: n/a >Fix: If maintainer agrees, apply below patch. diff -ruN mutt-devel.orig/Makefile mutt-devel/Makefile --- mutt-devel.orig/Makefile Wed May 18 07:00:52 2005 +++ mutt-devel/Makefile Wed May 18 07:14:05 2005 @@ -96,7 +96,7 @@ PORTNAME= mutt-devel PORTVERSION= 1.5.9 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES+= mail ipv6 .if defined(WITH_MUTT_NNTP) CATEGORIES+= news @@ -192,7 +192,6 @@ .if defined (MUTT_LITE) WITHOUT_MUTT_SGMLFORMAT= yes -WITHOUT_NLS= yes WITHOUT_MUTT_COMPRESSED_FOLDERS= yes WITHOUT_MUTT_QUOTE_PATCH= yes WITHOUT_MUTT_HTML= yes >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505181419.j4IEJFSl012559>