Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jul 2011 23:35:21 GMT
From:      Takuya ASADA <syuu@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 196466 for review
Message-ID:  <201107202335.p6KNZLHg005763@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@196466?ac=10

Change 196466 by syuu@kikurage on 2011/07/20 23:34:47

	NULL check is not needed for free(9), pointed out by Joshua Neal

Affected files ...

.. //depot/projects/soc2011/mq_bpf/src/sys/net/bpf.c#18 edit

Differences ...

==== //depot/projects/soc2011/mq_bpf/src/sys/net/bpf.c#18 (text+ko) ====

@@ -1577,10 +1577,8 @@
 			}
 			d->bd_qmask.qm_enabled = FALSE;
 			
-			if (d->bd_qmask.qm_rxq_mask != NULL)
-				free(d->bd_qmask.qm_rxq_mask, M_BPF);
-			if (d->bd_qmask.qm_txq_mask != NULL)
-				free(d->bd_qmask.qm_txq_mask, M_BPF);
+			free(d->bd_qmask.qm_rxq_mask, M_BPF);
+			free(d->bd_qmask.qm_txq_mask, M_BPF);
 			BPFQ_WUNLOCK(&d->bd_qmask);
 			break;
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107202335.p6KNZLHg005763>