Date: Thu, 31 Aug 2000 10:36:28 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Archie Cobbs <archie@whistle.com> Cc: committers@FreeBSD.org, net@FreeBSD.org, Garrett Wollman <wollman@FreeBSD.org>, Bill Fenner <fenner@FreeBSD.org>, Darren Reed <darrenr@FreeBSD.org>, Kannan Varadhan <kannanv@malgudi.research.bell-labs.com>, Frank Volf <volf@oasis.IAEhv.nl> Subject: Re: [Call for review] ICMP error generation fixes Message-ID: <20000831103628.A4165@sunbay.com> In-Reply-To: <200008301724.KAA30942@bubba.whistle.com>; from archie@whistle.com on Wed, Aug 30, 2000 at 10:24:21AM -0700 References: <20000830150327.C69333@sunbay.com> <200008301724.KAA30942@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 30, 2000 at 10:24:21AM -0700, Archie Cobbs wrote: > Ruslan Ermilov writes: > > http://people.FreeBSD.org/~ru/icmp-fixes.2 > > > > 5. Following the suggestion from Darren Reed, ip_output() now expects all > > three fields, ip_len, ip_off and ip_id(!) in host byte order. It was > > You need to add a NTOHS(ip->ip_id) to div_output() as well. > Yesterday when I was going to go home I found this bug myself, i.e. outgoing packets after being diverted were sent with wrong ip_id, and later, being already at home, I figured I forgot to modify div_output(). > Did you grep for all occurrences of calls to ip_output()? > There may be others as well. > Will give it a more close look... Thanks for review, Archie! -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000831103628.A4165>