Date: Mon, 30 Apr 2001 08:54:15 -0700 From: Doug Barton <DougB@DougBarton.net> To: Kris Kennaway <kris@obsecurity.org> Cc: Akinori MUSHA <knu@iDaemons.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/fox/files patch-ad Message-ID: <3AED8AA7.79931098@DougBarton.net> References: <200104300810.f3U8AGY60114@freefall.freebsd.org> <86elua4wf1.wl@archon.local.idaemons.org> <20010430023347.A70094@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote:
>
> On Mon, Apr 30, 2001 at 05:35:46PM +0900, Akinori MUSHA wrote:
> > At Mon, 30 Apr 2001 01:10:16 -0700 (PDT),
> > kkenn wrote:
> > > kris 2001/04/30 01:10:16 PDT
> > >
> > > Modified files:
> > > x11-toolkits/fox/files patch-ad
> > > Log:
> > > Don't hard-code -O2 and various -f optimizations in CXXFLAGS
> > >
> > > Revision Changes Path
> > > 1.2 +37 -5 ports/x11-toolkits/fox/files/patch-ad
> >
> > Thanks, but I wasn't asked for a review in advance on this... At a
> > glance, I noticed that /usr/local was hardcoded, which might be evil.
> >
> > Also, I haven't yet tested if this big monster of a toolkit works with
> > optimization flags other than "-O2 -ffast-math -finline-functions
> > -fomit-frame-pointer -fexpensive-optimizations". I wish you had
> > pointed it to me rather than just committing directly.
>
> Well, the policy from all quarters of the project is that everything
> over -O is dangerous and is known to break.
. . . unless the code has been tested with further optimizations. I tend
to agree with Knu here. Nothing would have been harmed by running these
changes through the maintainers to see if perhaps there was a reason for
the status quo. Too often lately we (and I'm speaking collectively here,
not ragging on Kris necessarily) have justified lack of review by saying
that, "If I had to wait for review, the change would not have been made."
In cases like this where nothing is demonstrably broken, my opinion is that
lack of change is not the end of the world.
Doug
--
I need someone really bad. Are you really bad?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AED8AA7.79931098>