Date: Sun, 01 Feb 2009 15:36:39 -0500 From: "Stephane E. Potvin" <sepotvin@videotron.ca> To: Ralph Zitz <ralph@imada.sdu.dk> Cc: freebsd-current@freebsd.org Subject: Re: patch r187693 breaks HAL on amd64-current Message-ID: <498607D7.7090507@videotron.ca> In-Reply-To: <4985FA10.5080604@imada.sdu.dk> References: <4985FA10.5080604@imada.sdu.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------000006000800080802060307 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ralph Zitz wrote: > I'm not a HAL expert, but it seems that the patch makes HAL create a > zombie process when watching /dev/cd0. Reversing the patch makes HAL > work again. > > Link to patch message: > http://lists.freebsd.org/pipermail/svn-src-all/2009-January/004073.html > Hi Ralph Try the following patch, it should fix your problem with hal. Regards Steph -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmGB9YACgkQmdOXtTCX/nt8tACgj5IzDaHDEsKIJbZPefOwzkiW Ne4AoMV4GzfMLeVeBAWIRbmG08R7Lpj3 =K7Cu -----END PGP SIGNATURE----- --------------000006000800080802060307 Content-Type: text/plain; name="lp64_select_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="lp64_select_fix.diff" Index: kern/sys_generic.c =================================================================== --- kern/sys_generic.c (revision 187983) +++ kern/sys_generic.c (working copy) @@ -903,7 +903,7 @@ * bit position in the fd_mask array. */ static __inline int -selflags(fd_mask **ibits, int idx, int bit) +selflags(fd_mask **ibits, int idx, fd_mask bit) { int flags; int msk; @@ -912,7 +912,7 @@ for (msk = 0; msk < 3; msk++) { if (ibits[msk] == NULL) continue; - if ((ibits[msk][idx] & (fd_mask)bit) == 0) + if ((ibits[msk][idx] & bit) == 0) continue; flags |= select_flags[msk]; } --------------000006000800080802060307 Content-Type: application/octet-stream; name="lp64_select_fix.diff.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="lp64_select_fix.diff.sig" iEYEABECAAYFAkmGB9cACgkQmdOXtTCX/nsf4gCcDVFWR3lmMVC6/G61MjPL81getI8AoOVT y6q1IMkYWZgzpZLXu0Ig9fHQ --------------000006000800080802060307--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?498607D7.7090507>