Date: Fri, 26 Jan 2018 11:14:16 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> Cc: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328402 - head/sys/dev/usb/controller Message-ID: <20180126111416.21d99403b0ff40c06d610990@bidouilliste.com> In-Reply-To: <20180125171452.GA61523@bsdpad.com> References: <201801251658.w0PGwNcq058492@repo.freebsd.org> <20180125181204.bb006fbb3a9bcd4acb4236af@bidouilliste.com> <20180125171452.GA61523@bsdpad.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Jan 2018 17:14:52 +0000 Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk> wrote: > On Thu, Jan 25, 2018 at 06:12:04PM +0100, Emmanuel Vadot wrote: > > > Log: > > > Add basic driver for Qualcomm USB 2.0 EHCI controller. > > > This driver relies on system initialization in u-boot. > > > > > > Tested on DragonBoard 410c. > > > > > > Sponsored by: DARPA, AFRL > > > > > > Added: > > > head/sys/dev/usb/controller/ehci_msm.c (contents, props changed) > > > > > > > The code looks like the generic-ehci, would it be better to subclass > > generic-ehci to fdt and add qualcomm quirks if necessary ? > > > > Hi Emmanuel > > This driver is incomplete currently and requires initialization in u-boot. > > Both system clocks and EHCI subsystem, also Qualcomm power management device requires full initialization. > My goal will be to extend this driver and proceed full initialization required for Qualcomm EHCI. Yes I can see that all the clock/reset/phy management is not yet done. But the generic-ehci driver should be subclassed so you can re-use the ehdi generic code in your driver. Then you will just need the attach function to deal the clock/reset/phy. > The u-boot option CONFIG_DM_DEVICE_REMOVE=n must be added in order to keep devices initialized before jumping to FreeBSD. We will need to get rid of these by adding some code to this driver I guess. > > Thanks. > > Ruslan -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180126111416.21d99403b0ff40c06d610990>