Date: Thu, 4 Sep 2008 20:02:32 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: Rafal Jaworowski <raj@semihalf.com> Cc: freebsd-arm@freebsd.org, Olivier Houchard <cognet@ci0.org> Subject: Re: ARM interrupts fixes Message-ID: <20080904200232.a8b556c9.stas@FreeBSD.org> In-Reply-To: <48BFE533.7010602@semihalf.com> References: <48BFE533.7010602@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Thu__4_Sep_2008_20_02_32_+0400_j9GY3Ay_WRMoIA18 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 04 Sep 2008 15:40:03 +0200 Rafal Jaworowski <raj@semihalf.com> mentioned: > Hi, > Please review the following changes around interrupts handling in ARM. We > already started discussing these items with Olivier some time ago: >=20 > 1. http://people.freebsd.org/~raj/patches/arm/intr-fixes.diff >=20 > At the moment nexus_setup_intr() attempts to set up a number of IRQs in o= ne > take, calling arm_setup_irqhandler() in loop. This is bogus, as there's j= ust > one cookie given from the caller and it is overwritten in each iteration = so > that only the last handler's cookie value prevails... >=20 > This patch removes such behaviour, however there's one [mis]user of the o= ld > approach i.e. the IXP425 qmgr, which needs adjustments too, see p.2. >=20 > Apart from style fixes, another problem which is corrected in this patch = is > the unmasking the IRQ source in the PIC after the last handler has been > removed from list. >=20 The patch looks goot to me. But what about splitting the whitespace fixes and the meaningful ones when committing to the tree to not pollute the history? --=20 Stanislav Sedov ST4096-RIPE --Signature=_Thu__4_Sep_2008_20_02_32_+0400_j9GY3Ay_WRMoIA18 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjABpwACgkQK/VZk+smlYG3/ACfX87Wmyd57FkDz/iCMudyY/D7 48oAoIC2ezdhO664ByJ1rjDLhSWNyOBp =M+ra -----END PGP SIGNATURE----- --Signature=_Thu__4_Sep_2008_20_02_32_+0400_j9GY3Ay_WRMoIA18--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080904200232.a8b556c9.stas>