Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Jul 2003 09:19:05 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Ruslan Ermilov <ru@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: cvs commit: src/release Makefile
Message-ID:  <20030731161905.GB69708@dragon.nuxi.com>
In-Reply-To: <XFMail.20030730153503.jhb@FreeBSD.org>
References:  <200307250855.h6P8tpCr098669@repoman.freebsd.org> <XFMail.20030730153503.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 30, 2003 at 03:35:03PM -0400, John Baldwin wrote:
> 
> On 25-Jul-2003 Ruslan Ermilov wrote:
> > ru          2003/07/25 01:55:51 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     release              Makefile 
> >   Log:
> >   The RELEASE9 knob is now OBE.
> >   
> >   OK'ed by:       jhb
> 
> No, it is _not_ ok'd.  You committed this before I had reviewed
> the actual patch and not in the manner I had stated.  Please
> have more patience.

Yes RU.

"make release.9" should build all the "floppies" and related bits.
W/in release/Makefile there should be this rule:

    release.9: release.9.${TARGET_ARCH}

for convieance sake.  'release.10' would build the BOOTMFS kernel.
'release.11' would make the cdrom boot image (ie, the "huge" flopy).
'release.12' would make say the driver floppy.

Then each release.9.${TARGET_ARCH} target should issue "${MAKE}
release.10 FDSIZE=<propersize>", those needing a driver floppy would
issue ""${MAKE} release.12 <KNOB>=<proper value>", etc...

Think C -- small subroutines w/o #ifdef's are good.

-- 
-- David  (obrien@FreeBSD.org)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030731161905.GB69708>