Date: Fri, 17 Feb 2017 10:24:08 +0000 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= <trasz@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313854 - head/sys/cam/ctl Message-ID: <20170217102408.GA74901@brick> In-Reply-To: <201702170522.v1H5MwGK027647@repo.freebsd.org> References: <201702170522.v1H5MwGK027647@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 0217T0522, Alexander Motin wrote: > Author: mav > Date: Fri Feb 17 05:22:58 2017 > New Revision: 313854 > URL: https://svnweb.freebsd.org/changeset/base/313854 > > Log: > Change the way MaxCmdSN is used. > > Before this change MaxCmdSN was reported as CmdSN + delta, that made it > limit number of requests in transmission from the initiator to target, > that was pretty useless. After this change MaxCmdSN limits number of > requests queued to CTL, i.e. maximal queue depth for the initiator. > The default limit is 256 outstanding requests per initiator at a time. > > This code uses existing cs_outstanding_ctl_pdus counter to track queue > depth. It's semantics doen't perfectly match, but close enough to not > add another counter. Just don't set the maxtags below 2. I like the change in principle, but I don't like the gratuitous change of sysctl name. It will break people's configs. Could you rename it back? Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170217102408.GA74901>