Date: Thu, 26 Dec 2013 11:28:28 +0100 From: Pawel Pekala <pawel@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r337439 - head/www/cntlm Message-ID: <20131226112828.4487544a@FreeBSD.org> In-Reply-To: <20131226051343.GA69157@FreeBSD.org> References: <201312251916.rBPJGnSw066524@svn.freebsd.org> <20131226051343.GA69157@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Alexey, On 2013-12-26 05:13 +0000, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >On Wed, Dec 25, 2013 at 07:16:49PM +0000, Pawel Pekala wrote: >> New Revision: 337439 >> URL: http://svnweb.freebsd.org/changeset/ports/337439 >>=20 >> Log: >> Fix build on -current >> =20 >> [...] >> do-install: >> - ${INSTALL_PROGRAM} ${WRKSRC}/cntlm ${STAGEDIR}${PREFIX}/bin/ >> - ${INSTALL_DATA} ${WRKSRC}/doc/cntlm.conf >> ${STAGEDIR}${PREFIX}/etc/cntlm.conf.sample >> - ${INSTALL_MAN} ${WRKSRC}/doc/cntlm.1 >> ${STAGEDIR}${MAN1PREFIX}/man/man1 >> + (cd ${WRKSRC} && ${INSTALL_PROGRAM} cntlm \ >> + ${STAGEDIR}${PREFIX}/bin) >> + (cd ${WRKSRC}/doc && ${INSTALL_DATA} cntlm.conf.sample \ >> + ${STAGEDIR}${PREFIX}/etc) >> + (cd ${WRKSRC}/doc && ${INSTALL_MAN} cntlm.1 \ >> + ${STAGEDIR}${MANPREFIX}/man/man1) > >Pawel, > >The last hunk has nothing to do with "fixing the build on current", it >makes the code harder to read (6 lines instead of three, line >wrapping), and is a gratuitous (and plain bad) change. > >I appreciate Katobot's build fixing PR's and patches, but let's not >take them as perfect and use it in their entirety, esp. when they >contradict our normal practices and style. Firstly I find it disrespectful to call someone a 'bot', please don't go there. I treat every PR the same - fix small stuff by myself, communicate about larger issues and wait for improved version. Kato's PRs are not exception from this, I fix trivial things mostly and many commits are not verbatim copy from PR. Thanks for pointing out this issue to me, I will more careful about these in the future. --=20 pozdrawiam / with regards Pawe=B3 P=EAkala
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131226112828.4487544a>