Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Nov 2013 08:32:25 +0400 (MSK)
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        mi@aldan.algebra.com
Subject:   ports/184347: [PATCH] graphics/vips: multiple fixes and bugs
Message-ID:  <20131128043225.7349D425@hades.panopticon>
Resent-Message-ID: <201311280450.rAS4o3nW082688@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         184347
>Category:       ports
>Synopsis:       [PATCH] graphics/vips: multiple fixes and bugs
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 28 04:50:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 10.0-BETA3 amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r258666: Wed Nov 27 03:06:10 MSK
>Description:
- Fix typo on option description
- Add DOCS to options
- Fix build on 10.x by not linking to nonexistent libstdc++

The port also fails to configure with DOCS disabled:

---
...
config.status: creating tools/Makefile
config.status: creating tools/batch_crop
config.status: creating tools/batch_image_convert
config.status: creating tools/batch_rubber_sheet
config.status: creating tools/light_correct
config.status: creating tools/shrink_width
config.status: creating swig/Makefile
config.status: creating swig/vipsCC/Makefile
config.status: creating swig/python/setup.py
config.status: creating man/Makefile
config.status: error: cannot find input file: `doc/Makefile.in'
gmake[1]: *** [Makefile] Error 1
gmake[1]: Leaving directory `/usr/home/amdmi3/projects/freebsd/ports/graphics/vips/work/vips-7.26.3'
===> Compilation failed unexpectedly.
---

There should be less brutal way of disabling docs installation. For instance, with staging and PORTDOCS=* this will be done automatically.

Port maintainer (mi@aldan.algebra.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: SVN)
>How-To-Repeat:
>Fix:

--- vips-7.26.3_7.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 335075)
+++ Makefile	(working copy)
@@ -10,9 +10,9 @@
 MAINTAINER=	mi@aldan.algebra.com
 COMMENT=	Free image processing system
 
-OPTIONS_DEFINE=	LIBOIL PYTHON
+OPTIONS_DEFINE=	LIBOIL PYTHON DOCS
 OPTIONS_DEFAULT=	LIBOIL
-LIBOIL_DESC=	Use leiboil for CPU-optimized primitives
+LIBOIL_DESC=	Use liboil for CPU-optimized primitives
 PYTHON_DESC=	Create Python bindings
 
 BUILD_DEPENDS=	p5-XML-Parser>=0:${PORTSDIR}/textproc/p5-XML-Parser
@@ -81,4 +81,8 @@
 CONFIGURE_ARGS+=	--without-liboil
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e '/VIPS_CXX_LIBS="-lstdc++"/ d' \
+		${WRKSRC}/configure.in ${WRKSRC}/configure
+
 .include <bsd.port.post.mk>
--- vips-7.26.3_7.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131128043225.7349D425>